Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 7756004: Create a new GrGLInterface for each GrContext so callback can be used to set GL-context (Closed)

Created:
9 years, 3 months ago by bsalomon
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Create a GrGLInterface per-GrContext in Chrome. We do this so that its per-GL-function callback can be used to set the correct GL context. See also: https://bugs.webkit.org/show_bug.cgi?id=67395 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99733

Patch Set 1 #

Patch Set 2 : remove accidentally included autogen file #

Patch Set 3 : Create a new GrGLInterface for each GrContext so callback can be used to set GL-context #

Patch Set 4 : switch machines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -248 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.cc View 1 2 3 1 chunk +128 lines, -132 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.cc View 1 2 3 1 chunk +99 lines, -103 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
PTAL
9 years, 3 months ago (2011-09-02 14:40:39 UTC) #1
Ken Russell (switch to Gerrit)
LGTM
9 years, 3 months ago (2011-09-02 18:57:41 UTC) #2
tony
webkit/glue LGTM
9 years, 3 months ago (2011-09-02 19:02:36 UTC) #3
Jeff Timanus
9 years, 3 months ago (2011-09-02 19:13:20 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698