Issue 7746004: Fix crash with some keyboard shortcuts in Cocoa Panels.

Issue 7746004: Fix crash with some keyboard shortcuts in Cocoa Panels. (Closed)

Created:
9 years, 4 months ago by jennb

Modified:
9 years, 4 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, jennb, jianli, prasadt, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash with some keyboard shortcuts in Cocoa Panels. ChromeEventProcessingWindow expects the window's controller to implement BrowserCommandExecutor. Oops. Added. BUG=None TEST=PanelBrowserWindowCocoaTest.KeyEvent Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98493

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include Cocoa.h explicitly. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -1 line)			Patch
M	chrome/browser/ui/panels/panel_browser_window_cocoa.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

http://codereview.chromium.org/7746004/diff/1/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm File chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm (right): http://codereview.chromium.org/7746004/diff/1/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm#newcode7 chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm:7: #include <Carbon/Carbon.h> Why this change? Don't you now rely ...

9 years, 4 months ago (2011-08-24 23:27:45 UTC) #2

jennb

9 years, 4 months ago (2011-08-24 23:29:30 UTC) #3

Dmitry Titov

9 years, 4 months ago (2011-08-25 00:10:54 UTC) #4

LGTM with also including Cocoa.h in unittest file. We often get away without
including it because there are other .h files that bring it in, but the rule is
to include what you use, not depending on other .h files.

Expand Messages | Collapse Messages