Fix crash with some keyboard shortcuts in Cocoa Panels.

chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
 
-#import <Cocoa/Cocoa.h>
+#include <Carbon/Carbon.h>

[Dmitry Titov, 2011/08/24 23:27:46]

Why this change? Don't you now rely on one of the included .h files to import
Cocoa?

[jennb, 2011/08/24 23:29:30]

kVK_Tab was not defined until I made this change.

 
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #import "chrome/browser/ui/cocoa/browser_test_helper.h"
+#import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #import "chrome/browser/ui/panels/panel_titlebar_view_cocoa.h"
 #import "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
@@ skipping 274 matching lines @@
   EXPECT_TRUE([close_window_menu_item isEnabled]);
   EXPECT_TRUE([find_menu_item isEnabled]);
   EXPECT_TRUE([find_previous_menu_item isEnabled]);
   EXPECT_TRUE([find_next_menu_item isEnabled]);
   EXPECT_FALSE([fullscreen_menu_item isEnabled]);
   EXPECT_FALSE([presentation_menu_item isEnabled]);
   EXPECT_FALSE([bookmarks_menu_item isEnabled]);
 
   ClosePanelAndWait(panel->browser());
 }
+
+TEST_F(PanelBrowserWindowCocoaTest, KeyEvent) {
+  Panel* panel = CreateTestPanel("Test Panel");
+  NSEvent* event = [NSEvent keyEventWithType:NSKeyDown
+                                    location:NSZeroPoint
+                               modifierFlags:NSControlKeyMask
+                                   timestamp:0.0
+                                windowNumber:0
+                                     context:nil
+                                  characters:@""
+                 charactersIgnoringModifiers:@""
+                                   isARepeat:NO
+                                     keyCode:kVK_Tab];
+  PanelBrowserWindowCocoa* native_window =
+      static_cast<PanelBrowserWindowCocoa*>(panel->native_panel());
+  [BrowserWindowUtils handleKeyboardEvent:event
+                      inWindow:[native_window->controller_ window]];
+  ClosePanelAndWait(panel->browser());
+}