chrome/browser/ui/panels/panel_window_controller_cocoa.mm - Issue 7746004: Fix crash with some keyboard shortcuts in Cocoa Panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 7746004: Fix crash with some keyboard shortcuts in Cocoa Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Include Cocoa.h explicitly. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

index d48f204f791c34606f217a459d1b3d728ee1b427..b6f2aae424c00fb859214049b4032fd1b2ab2857 100644

--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

@@ -170,6 +170,10 @@ const int kMinimumWindowSize = 1;

[sender tag], disposition);

}

+- (void)executeCommand:(int)command {

+ windowShim_->browser()->ExecuteCommandIfEnabled(command);

// Handler for the custom Close button.

- (void)closePanel {

windowShim_->panel()->Close();

« no previous file with comments | « chrome/browser/ui/panels/panel_window_controller_cocoa.h ('k') | no next file » | no next file with comments »