chrome/browser/sync/internal_api/sync_manager.cc - Issue 7731002: sync: make ServerConnectionManager explicitly NonThreadSafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/internal_api/sync_manager.cc

Issue 7731002: sync: make ServerConnectionManager explicitly NonThreadSafe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: initial Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/internal_api/sync_manager.cc

diff --git a/chrome/browser/sync/internal_api/sync_manager.cc b/chrome/browser/sync/internal_api/sync_manager.cc

index c0b9cb35ff7e9c075139b36b90fff849a036970b..2303b474534e799ce29ba398daff9e989b8d8363 100644

--- a/chrome/browser/sync/internal_api/sync_manager.cc

+++ b/chrome/browser/sync/internal_api/sync_manager.cc

@@ -1281,6 +1281,7 @@ void SyncManager::SyncInternal::OnIPAddressChanged() {

}

void SyncManager::SyncInternal::OnIPAddressChangedImpl() {

+ DCHECK(thread_checker_.CalledOnValidThread());

// TODO(akalin): CheckServerReachable() can block, which may cause

// jank if we try to shut down sync. Fix this.

connection_manager()->CheckServerReachable();