sync: make ServerConnectionManager explicitly NonThreadSafe

chrome/test/sync/engine/mock_connection_manager.cc

Index: chrome/test/sync/engine/mock_connection_manager.cc
diff --git a/chrome/test/sync/engine/mock_connection_manager.cc b/chrome/test/sync/engine/mock_connection_manager.cc
index d7a06d677640627e34d8ad845588f4b926a1cfb3..1667f797e817c2071bfbf5d08df6db771cdc9bd1 100644
--- a/chrome/test/sync/engine/mock_connection_manager.cc
+++ b/chrome/test/sync/engine/mock_connection_manager.cc
@@ -609,14 +609,16 @@ void MockConnectionManager::SetServerReachable() {
   server_status_ = HttpResponse::SERVER_CONNECTION_OK;
   server_reachable_ = true;
 
-  listeners_->Notify(&ServerConnectionEventListener::OnServerConnectionEvent,
-      ServerConnectionEvent(server_status_, server_reachable_));
+  FOR_EACH_OBSERVER(ServerConnectionEventListener, listeners_,
+     OnServerConnectionEvent(

[lipalani1, 2011/08/24 20:35:28]

You can simply call NotifyStatusChanged

+         ServerConnectionEvent(server_status_, server_reachable_)));
 }
 
 void MockConnectionManager::SetServerNotReachable() {
   server_status_ = HttpResponse::CONNECTION_UNAVAILABLE;
   server_reachable_ = false;
 
-  listeners_->Notify(&ServerConnectionEventListener::OnServerConnectionEvent,
-      ServerConnectionEvent(server_status_, server_reachable_));
+  FOR_EACH_OBSERVER(ServerConnectionEventListener, listeners_,
+     OnServerConnectionEvent(

[lipalani1, 2011/08/24 20:35:28]

Same as above.

+         ServerConnectionEvent(server_status_, server_reachable_)));
 }