Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 7724002: Turn off PIE when building for Valgrind (Closed)

Created:
9 years, 4 months ago by Mark Mentovai
Modified:
9 years, 4 months ago
Reviewers:
cbentzel, TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Turn off PIE when building for Valgrind. BUG=90221, 93551 TEST=Valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98046

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
M build/mac/change_mach_o_flags_from_xcode.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
9 years, 4 months ago (2011-08-24 14:49:58 UTC) #1
TVL
lgtm
9 years, 4 months ago (2011-08-24 14:54:21 UTC) #2
cbentzel
9 years, 4 months ago (2011-08-24 14:56:01 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698