Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: build/common.gypi

Issue 7724002: Turn off PIE when building for Valgrind (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/mac/change_mach_o_flags_from_xcode.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1670 matching lines...) Expand 10 before | Expand all | Expand 10 after
1681 # Arranges for data (heap) pages to be protected against 1681 # Arranges for data (heap) pages to be protected against
1682 # code execution when running on Mac OS X 10.7 ("Lion"), and 1682 # code execution when running on Mac OS X 10.7 ("Lion"), and
1683 # ensures that the position-independent executable (PIE) bit 1683 # ensures that the position-independent executable (PIE) bit
1684 # is set for ASLR when running on Mac OS X 10.5 ("Leopard"). 1684 # is set for ASLR when running on Mac OS X 10.5 ("Leopard").
1685 'variables': { 1685 'variables': {
1686 # Define change_mach_o_flags in a variable ending in _path 1686 # Define change_mach_o_flags in a variable ending in _path
1687 # so that GYP understands it's a path and performs proper 1687 # so that GYP understands it's a path and performs proper
1688 # relativization during dict merging. 1688 # relativization during dict merging.
1689 'change_mach_o_flags_path': 1689 'change_mach_o_flags_path':
1690 'mac/change_mach_o_flags_from_xcode.sh', 1690 'mac/change_mach_o_flags_from_xcode.sh',
1691 'change_mach_o_flags_options': [
1692 ],
1693 'target_conditions': [
1694 ['release_valgrind_build==1', {
1695 'change_mach_o_flags_options': [
1696 # Turn off PIE when building for Valgrind because
1697 # Valgrind doesn't understand slide. TODO: Make
1698 # Valgrind on Mac OS X understand slide, and get rid
1699 # of the Valgrind check.
1700 '--no-pie',
1701 ],
1702 }],
1703 ],
1691 }, 1704 },
1692 'postbuild_name': 'Change Mach-O Flags', 1705 'postbuild_name': 'Change Mach-O Flags',
1693 'action': [ 1706 'action': [
1694 '<(change_mach_o_flags_path)', 1707 '<(change_mach_o_flags_path)',
1708 '>@(change_mach_o_flags_options)',
1695 ], 1709 ],
1696 }, 1710 },
1697 ], 1711 ],
1698 }], 1712 }],
1699 ['_type=="executable" and release_valgrind_build==0', { 1713 ['_type=="executable" and release_valgrind_build==0', {
1700 # Turn on position-independence (ASLR) for executables. When PIE 1714 # Turn on position-independence (ASLR) for executables. When PIE
1701 # is on for the Chrome executables, the framework will also be 1715 # is on for the Chrome executables, the framework will also be
1702 # subject to ASLR. 1716 # subject to ASLR.
1703 # Don't do this when building for Valgrind because Valgrind 1717 # Don't do this when building for Valgrind because Valgrind
1704 # doesn't understand slide. TODO: Make Valgrind on Mac OS X 1718 # doesn't understand slide. TODO: Make Valgrind on Mac OS X
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
1971 # settings in target dicts. SYMROOT is a special case, because many other 1985 # settings in target dicts. SYMROOT is a special case, because many other
1972 # Xcode variables depend on it, including variables such as 1986 # Xcode variables depend on it, including variables such as
1973 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 1987 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
1974 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 1988 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
1975 # files to appear (when present) in the UI as actual files and not red 1989 # files to appear (when present) in the UI as actual files and not red
1976 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 1990 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
1977 # and therefore SYMROOT, needs to be set at the project level. 1991 # and therefore SYMROOT, needs to be set at the project level.
1978 'SYMROOT': '<(DEPTH)/xcodebuild', 1992 'SYMROOT': '<(DEPTH)/xcodebuild',
1979 }, 1993 },
1980 } 1994 }
OLDNEW
« no previous file with comments | « no previous file | build/mac/change_mach_o_flags_from_xcode.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698