Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: build/common.gypi

Issue 7724002: Turn off PIE when building for Valgrind (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/mac/change_mach_o_flags_from_xcode.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 97984)
+++ build/common.gypi (working copy)
@@ -1688,10 +1688,24 @@
# relativization during dict merging.
'change_mach_o_flags_path':
'mac/change_mach_o_flags_from_xcode.sh',
+ 'change_mach_o_flags_options': [
+ ],
+ 'target_conditions': [
+ ['release_valgrind_build==1', {
+ 'change_mach_o_flags_options': [
+ # Turn off PIE when building for Valgrind because
+ # Valgrind doesn't understand slide. TODO: Make
+ # Valgrind on Mac OS X understand slide, and get rid
+ # of the Valgrind check.
+ '--no-pie',
+ ],
+ }],
+ ],
},
'postbuild_name': 'Change Mach-O Flags',
'action': [
'<(change_mach_o_flags_path)',
+ '>@(change_mach_o_flags_options)',
],
},
],
« no previous file with comments | « no previous file | build/mac/change_mach_o_flags_from_xcode.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698