chrome/renderer/print_web_view_helper.h - Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper.h

Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/print_web_view_helper.h

diff --git a/chrome/renderer/print_web_view_helper.h b/chrome/renderer/print_web_view_helper.h

index b1244f36a50e648fb54ebc0e409560da7b8ca71c..152d71f54482c36a19732afcd4825e2441fc0daa 100644

--- a/chrome/renderer/print_web_view_helper.h

+++ b/chrome/renderer/print_web_view_helper.h

@@ -234,7 +234,8 @@ class PrintWebViewHelper : public RenderViewObserver,

#elif defined(OS_MACOSX)

void RenderPage(const gfx::Size& page_size, const gfx::Rect& content_area,

const float& scale_factor, int page_number,

- WebKit::WebFrame* frame, printing::Metafile* metafile);

+ WebKit::WebFrame* frame, printing::Metafile* metafile,

+ bool is_preview);

vandebo (ex-Chrome) 2011/09/26 17:33:05 metafile is effectively an output parameter, so is

kmadhusu 2011/09/26 20:42:22 Done.

#elif defined(OS_POSIX)

bool RenderPages(const PrintMsg_PrintPages_Params& params,

WebKit::WebFrame* frame, WebKit::WebNode* node,

« no previous file with comments | « no previous file | chrome/renderer/print_web_view_helper_mac.mm » ('j') | printing/metafile_skia_wrapper.h » ('J')