PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF

chrome/renderer/print_web_view_helper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_PRINT_WEB_VIEW_HELPER_H_
 #define CHROME_RENDERER_PRINT_WEB_VIEW_HELPER_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 216 matching lines @@
   // need to create a new metafile.  The result may be either the passed
   // |metafile| or a new one.  In either case, the caller owns both |metafile|
   // and the result.
   printing::Metafile* RenderPage(const PrintMsg_Print_Params& params,
                                  float* scale_factor, int page_number,
                                  bool is_preview, WebKit::WebFrame* frame,
                                  printing::Metafile* metafile);
 #elif defined(OS_MACOSX)
   void RenderPage(const gfx::Size& page_size, const gfx::Rect& content_area,
                   const float& scale_factor, int page_number,
-                  WebKit::WebFrame* frame, printing::Metafile* metafile);
+                  WebKit::WebFrame* frame, printing::Metafile* metafile,
+                  bool is_preview);

[vandebo (ex-Chrome), 2011/09/26 17:33:05]

metafile is effectively an output parameter, so is_preview should go before it.
Probably best after page_number?

[kmadhusu, 2011/09/26 20:42:22]

Done.

 #elif defined(OS_POSIX)
   bool RenderPages(const PrintMsg_PrintPages_Params& params,
                    WebKit::WebFrame* frame, WebKit::WebNode* node,
                    int* page_count, PrepareFrameAndViewForPrint* prepare,
                    printing::Metafile* metafile);
 #endif  // defined(OS_WIN)
 
   // Helper methods -----------------------------------------------------------
 
   bool CopyAndPrint(WebKit::WebFrame* web_frame);
@@ skipping 186 matching lines @@
 
     State state_;
   };
 
   PrintPreviewContext print_preview_context_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintWebViewHelper);
 };
 
 #endif  // CHROME_RENDERER_PRINT_WEB_VIEW_HELPER_H_