Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3327)

Unified Diff: chrome/renderer/print_web_view_helper_mac.mm

Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/print_web_view_helper_mac.mm
diff --git a/chrome/renderer/print_web_view_helper_mac.mm b/chrome/renderer/print_web_view_helper_mac.mm
index 0e8c3b24133f3036f2bfdad5ef2ef4a43ad671cf..81bae400039df74ca3ba56f93e8f31aec028ba42 100644
--- a/chrome/renderer/print_web_view_helper_mac.mm
+++ b/chrome/renderer/print_web_view_helper_mac.mm
@@ -37,7 +37,7 @@ void PrintWebViewHelper::PrintPageInternal(
// Render page for printing.
gfx::Rect content_area(params.params.printable_size);
RenderPage(params.params.printable_size, content_area, scale_factor,
- page_number, frame, &metafile);
+ page_number, frame, &metafile, false);
metafile.FinishDocument();
PrintHostMsg_DidPrintPage_Params page_params;
@@ -96,7 +96,7 @@ bool PrintWebViewHelper::RenderPreviewPage(int page_number) {
base::TimeTicks begin_time = base::TimeTicks::Now();
RenderPage(printParams.page_size, content_area, scale_factor, page_number,
- print_preview_context_.frame(), initial_render_metafile);
+ print_preview_context_.frame(), initial_render_metafile, true);
print_preview_context_.RenderedPreviewPage(
base::TimeTicks::Now() - begin_time);
@@ -144,7 +144,7 @@ bool PrintWebViewHelper::RenderPreviewPage(int page_number) {
void PrintWebViewHelper::RenderPage(
const gfx::Size& page_size, const gfx::Rect& content_area,
const float& scale_factor, int page_number, WebFrame* frame,
- printing::Metafile* metafile) {
+ printing::Metafile* metafile, bool is_preview) {
{
#if defined(USE_SKIA)
@@ -159,6 +159,8 @@ void PrintWebViewHelper::RenderPage(
printing::MetafileSkiaWrapper::SetMetafileOnCanvas(canvas.get(), metafile);
printing::MetafileSkiaWrapper::SetDraftMode(canvas.get(),
is_print_ready_metafile_sent_);
+ printing::MetafileSkiaWrapper::SetIsPreviewMetafile(canvas.get(),
+ is_preview);
#else
bool success = metafile->StartPage(page_size, content_area, scale_factor);
DCHECK(success);

Powered by Google App Engine
This is Rietveld 408576698