Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 7718016: Revert 97943 - Switching NaCl IRT to be built inside the chrome build. (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
Reviewers:
bradn
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 97943 - Switching NaCl IRT to be built inside the chrome build. Third attempt: Switching IRT to be built inside the chrome build. Dropping the IRT download step from the DEPS. Step3 of a many step plan to switch where ppapi + irt are built. Dropping download_nacl_irt because we no longer rely on a prebuilt copy. Dropping irt download drop source tarball (assume people using it will have to download / build their own nacl toolchain). Old Review URL: http://codereview.chromium.org/7669058 R=noelallen@google.com BUG=http://code.google.com/p/chromium/issues/detail?id=93520 TEST=None Review URL: http://codereview.chromium.org/7685042 TBR=bradnelson@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -248 lines) Patch
M DEPS View 4 chunks +22 lines, -9 lines 0 comments Download
A + build/download_nacl_irt.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/build_nacl_irt.py View 1 chunk +0 lines, -186 lines 0 comments Download
M chrome/nacl.gypi View 2 chunks +18 lines, -54 lines 0 comments Download
M tools/export_tarball/export_tarball.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tony
9 years, 4 months ago (2011-08-23 23:51:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698