|
|
Created:
9 years, 4 months ago by bradn Modified:
9 years, 4 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionSwitching IRT to be built inside the chrome build.
Dropping the IRT download step from the DEPS.
Step3 of a many step plan to switch where ppapi + irt live / are built.
BUG=None
TEST=None
R=noelallen@google.com,brettw@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97429
Patch Set 1 #Patch Set 2 : '' #
Total comments: 1
Patch Set 3 : '' #Patch Set 4 : '' #Patch Set 5 : '' #Patch Set 6 : '' #Patch Set 7 : '' #Patch Set 8 : '' #Patch Set 9 : '' #Patch Set 10 : '' #Patch Set 11 : '' #Patch Set 12 : '' #Patch Set 13 : '' #
Messages
Total messages: 8 (0 generated)
LGTM+ Feel free to split the action into three cases if you feel it's worth it, otherwise it's fine as is. http://codereview.chromium.org/7669058/diff/2001/chrome/nacl.gypi File chrome/nacl.gypi (right): http://codereview.chromium.org/7669058/diff/2001/chrome/nacl.gypi#newcode98 chrome/nacl.gypi:98: 'action': [ I've never seen the case of appending to an action?
Oh, here's the list of inputs: ../base/at_exit.h ../base/atomic_ref_count.h ../base/atomicops.h ../base/atomicops_internals_arm_gcc.h ../base/atomicops_internals_atomicword_compat.h ../base/atomicops_internals_x86_gcc.h ../base/atomicops_internals_x86_macosx.h ../base/atomicops_internals_x86_msvc.h ../base/base_export.h ../base/basictypes.h ../base/callback.h ../base/callback_internal.h ../base/command_line.h ../base/compiler_specific.h ../base/debug/alias.h ../base/debug/trace_event.h ../base/hash_tables.h ../base/logging.h ../base/memory/raw_scoped_refptr_mismatch_checker.h ../base/memory/ref_counted.h ../base/memory/scoped_ptr.h ../base/memory/singleton.h ../base/memory/weak_ptr.h ../base/port.h ../base/string16.h ../base/string_piece.h ../base/string_util.h ../base/string_util_posix.h ../base/string_util_win.h ../base/synchronization/lock.h ../base/synchronization/lock_impl.h ../base/task.h ../base/template_util.h ../base/third_party/dynamic_annotations/dynamic_annotations.h ../base/threading/platform_thread.h ../base/threading/thread_checker.h ../base/threading/thread_checker_impl.h ../base/threading/thread_collision_warner.h ../base/threading/thread_restrictions.h ../base/time.h ../base/timer.h ../base/tracked.h ../base/tuple.h ../build/build_config.h ../gpu/GLES2/gl2.h ../gpu/GLES2/gl2ext.h ../gpu/GLES2/gl2platform.h ../gpu/KHR/khrplatform.h ../gpu/command_buffer/client/cmd_buffer_helper.h ../gpu/command_buffer/client/fenced_allocator.h ../gpu/command_buffer/client/gles2_c_lib_autogen.h ../gpu/command_buffer/client/gles2_cmd_helper.h ../gpu/command_buffer/client/gles2_cmd_helper_autogen.h ../gpu/command_buffer/client/gles2_implementation.h ../gpu/command_buffer/client/gles2_implementation_autogen.h ../gpu/command_buffer/client/gles2_lib.h ../gpu/command_buffer/client/mapped_memory.h ../gpu/command_buffer/client/program_info_manager.h ../gpu/command_buffer/client/ring_buffer.h ../gpu/command_buffer/common/bitfield_helpers.h ../gpu/command_buffer/common/buffer.h ../gpu/command_buffer/common/cmd_buffer_common.h ../gpu/command_buffer/common/command_buffer.h ../gpu/command_buffer/common/constants.h ../gpu/command_buffer/common/gles2_cmd_format.h ../gpu/command_buffer/common/gles2_cmd_format_autogen.h ../gpu/command_buffer/common/gles2_cmd_ids.h ../gpu/command_buffer/common/gles2_cmd_ids_autogen.h ../gpu/command_buffer/common/gles2_cmd_utils.h ../gpu/command_buffer/common/gles2_cmd_utils_autogen.h ../gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h ../gpu/command_buffer/common/id_allocator.h ../gpu/command_buffer/common/logging.h ../gpu/command_buffer/common/scoped_ptr.h ../gpu/command_buffer/common/thread_local.h ../gpu/command_buffer/common/trace_event.h ../gpu/command_buffer/common/types.h ../ui/gfx/gl/gl_switches.h ../native_client/src/include/atomic_ops.h ../native_client/src/include/checked_cast.h ../native_client/src/include/elf32.h ../native_client/src/include/elf_auxv.h ../native_client/src/include/elf_constants.h ../native_client/src/include/linux/arm/atomic_ops.h ../native_client/src/include/linux/x86/atomic_ops.h ../native_client/src/include/nacl/atomic_ops.h ../native_client/src/include/nacl/nacl_inttypes.h ../native_client/src/include/nacl_asm.h ../native_client/src/include/nacl_assert.h ../native_client/src/include/nacl_base.h ../native_client/src/include/nacl_compiler_annotations.h ../native_client/src/include/nacl_macros.h ../native_client/src/include/nacl_memory.h ../native_client/src/include/nacl_scoped_ptr.h ../native_client/src/include/osx/atomic_ops_osx.h ../native_client/src/include/portability.h ../native_client/src/include/portability_io.h ../native_client/src/include/portability_process.h ../native_client/src/include/portability_string.h ../native_client/src/include/ref_counted.h ../native_client/src/include/win/atomic_ops_win32.h ../native_client/src/include/win/port_win.h ../native_client/src/shared/gio/gio.c ../native_client/src/shared/gio/gio.h ../native_client/src/shared/gio/gio_mem.c ../native_client/src/shared/gio/gio_mem_snapshot.c ../native_client/src/shared/gio/gprintf.c ../native_client/src/shared/imc/nacl_imc_c.h ../native_client/src/shared/platform/linux/condition_variable.c ../native_client/src/shared/platform/linux/lock.c ../native_client/src/shared/platform/linux/nacl_exit.c ../native_client/src/shared/platform/linux/nacl_host_desc_types.h ../native_client/src/shared/platform/linux/nacl_thread_id.c ../native_client/src/shared/platform/linux/nacl_threads.c ../native_client/src/shared/platform/linux/nacl_threads_types.h ../native_client/src/shared/platform/linux/nacl_timestamp.c ../native_client/src/shared/platform/nacl_check.c ../native_client/src/shared/platform/nacl_check.h ../native_client/src/shared/platform/nacl_exit.h ../native_client/src/shared/platform/nacl_host_desc.h ../native_client/src/shared/platform/nacl_log.c ../native_client/src/shared/platform/nacl_log.h ../native_client/src/shared/platform/nacl_log_intern.h ../native_client/src/shared/platform/nacl_sync.h ../native_client/src/shared/platform/nacl_sync_checked.c ../native_client/src/shared/platform/nacl_sync_checked.h ../native_client/src/shared/platform/nacl_threads.h ../native_client/src/shared/platform/nacl_timestamp.h ../native_client/src/shared/platform/refcount_base.cc ../native_client/src/shared/platform/refcount_base.h ../native_client/src/shared/platform/win/nacl_host_desc_types.h ../native_client/src/shared/platform/win/nacl_threads_types.h ../native_client/src/shared/ppapi_proxy/browser_globals.h ../native_client/src/shared/ppapi_proxy/command_buffer/client/cmd_buffer_helper.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/fenced_allocator.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/gles2_c_lib.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/gles2_cmd_helper.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/gles2_implementation.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/gles2_lib.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/mapped_memory.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/program_info_manager.cc ../native_client/src/shared/ppapi_proxy/command_buffer/client/ring_buffer.cc ../native_client/src/shared/ppapi_proxy/command_buffer/common/cmd_buffer_common.cc ../native_client/src/shared/ppapi_proxy/command_buffer/common/gles2_cmd_format.cc ../native_client/src/shared/ppapi_proxy/command_buffer/common/gles2_cmd_utils.cc ../native_client/src/shared/ppapi_proxy/command_buffer/common/id_allocator.cc ../native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc ../native_client/src/shared/ppapi_proxy/command_buffer_nacl.h ../native_client/src/shared/ppapi_proxy/input_event_data.cc ../native_client/src/shared/ppapi_proxy/input_event_data.h ../native_client/src/shared/ppapi_proxy/object_serialize.cc ../native_client/src/shared/ppapi_proxy/object_serialize.h ../native_client/src/shared/ppapi_proxy/plugin_callback.cc ../native_client/src/shared/ppapi_proxy/plugin_callback.h ../native_client/src/shared/ppapi_proxy/plugin_context_3d.cc ../native_client/src/shared/ppapi_proxy/plugin_context_3d.h ../native_client/src/shared/ppapi_proxy/plugin_globals.cc ../native_client/src/shared/ppapi_proxy/plugin_globals.h ../native_client/src/shared/ppapi_proxy/plugin_instance_data.cc ../native_client/src/shared/ppapi_proxy/plugin_instance_data.h ../native_client/src/shared/ppapi_proxy/plugin_main.cc ../native_client/src/shared/ppapi_proxy/plugin_nacl_file.cc ../native_client/src/shared/ppapi_proxy/plugin_nacl_file.h ../native_client/src/shared/ppapi_proxy/plugin_opengles.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio_config.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio_config.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_core.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_core.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_cursor_control.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_cursor_control.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_ref.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_ref.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_system.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_system.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_find.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_find.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_font.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_font.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_2d.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_2d.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_input_event.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_input_event.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_instance.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_instance.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_memory.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_memory.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_messaging.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_messaging.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_testing.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_testing.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_loader.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_loader.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_request_info.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_request_info.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_response_info.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_response_info.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_var.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_var.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_widget.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_widget.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_zoom.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_zoom.h ../native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_input_event_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_instance_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_messaging_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_printing_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_scrollbar_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_widget_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_zoom_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_resource.cc ../native_client/src/shared/ppapi_proxy/plugin_resource.h ../native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc ../native_client/src/shared/ppapi_proxy/plugin_resource_tracker.h ../native_client/src/shared/ppapi_proxy/plugin_surface_3d.cc ../native_client/src/shared/ppapi_proxy/plugin_surface_3d.h ../native_client/src/shared/ppapi_proxy/plugin_threading.cc ../native_client/src/shared/ppapi_proxy/plugin_upcall.cc ../native_client/src/shared/ppapi_proxy/plugin_upcall.h ../native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc ../native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc ../native_client/src/shared/ppapi_proxy/ppruntime.h ../native_client/src/shared/ppapi_proxy/proxy_var.cc ../native_client/src/shared/ppapi_proxy/proxy_var.h ../native_client/src/shared/ppapi_proxy/proxy_var_cache.cc ../native_client/src/shared/ppapi_proxy/proxy_var_cache.h ../native_client/src/shared/ppapi_proxy/string_proxy_var.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/upcall.h ../native_client/src/shared/ppapi_proxy/upcall_client.cc ../native_client/src/shared/ppapi_proxy/utility.cc ../native_client/src/shared/ppapi_proxy/utility.h ../native_client/src/shared/srpc/accept.c ../native_client/src/shared/srpc/accept_threaded.c ../native_client/src/shared/srpc/invoke.c ../native_client/src/shared/srpc/module_init_fini.c ../native_client/src/shared/srpc/nacl_srpc.c ../native_client/src/shared/srpc/nacl_srpc.h ../native_client/src/shared/srpc/nacl_srpc_internal.h ../native_client/src/shared/srpc/nacl_srpc_message.c ../native_client/src/shared/srpc/nacl_srpc_message.h ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_init.c ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_internal.c ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_internal.h ../native_client/src/shared/srpc/rpc_log.c ../native_client/src/shared/srpc/rpc_serialize.c ../native_client/src/shared/srpc/rpc_server_loop.c ../native_client/src/shared/srpc/rpc_service.c ../native_client/src/third_party/dlmalloc/malloc.c ../native_client/src/third_party/ppapi/c/dev/deprecated_bool.h ../native_client/src/third_party/ppapi/c/dev/pp_cursor_type_dev.h ../native_client/src/third_party/ppapi/c/dev/pp_graphics_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_buffer_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_context_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_context_3d_trusted_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_cursor_control_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_find_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_font_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_memory_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_opengles_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_scrollbar_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_surface_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_testing_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_var_deprecated.h ../native_client/src/third_party/ppapi/c/dev/ppb_widget_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_zoom_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_find_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_printing_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_scrollbar_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_selection_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_widget_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_zoom_dev.h ../native_client/src/third_party/ppapi/c/pp_bool.h ../native_client/src/third_party/ppapi/c/pp_completion_callback.h ../native_client/src/third_party/ppapi/c/pp_errors.h ../native_client/src/third_party/ppapi/c/pp_file_info.h ../native_client/src/third_party/ppapi/c/pp_input_event.h ../native_client/src/third_party/ppapi/c/pp_instance.h ../native_client/src/third_party/ppapi/c/pp_macros.h ../native_client/src/third_party/ppapi/c/pp_module.h ../native_client/src/third_party/ppapi/c/pp_point.h ../native_client/src/third_party/ppapi/c/pp_rect.h ../native_client/src/third_party/ppapi/c/pp_resource.h ../native_client/src/third_party/ppapi/c/pp_size.h ../native_client/src/third_party/ppapi/c/pp_stdint.h ../native_client/src/third_party/ppapi/c/pp_time.h ../native_client/src/third_party/ppapi/c/pp_var.h ../native_client/src/third_party/ppapi/c/ppb.h ../native_client/src/third_party/ppapi/c/ppb_audio.h ../native_client/src/third_party/ppapi/c/ppb_audio_config.h ../native_client/src/third_party/ppapi/c/ppb_core.h ../native_client/src/third_party/ppapi/c/ppb_file_io.h ../native_client/src/third_party/ppapi/c/ppb_file_ref.h ../native_client/src/third_party/ppapi/c/ppb_file_system.h ../native_client/src/third_party/ppapi/c/ppb_graphics_2d.h ../native_client/src/third_party/ppapi/c/ppb_image_data.h ../native_client/src/third_party/ppapi/c/ppb_input_event.h ../native_client/src/third_party/ppapi/c/ppb_instance.h ../native_client/src/third_party/ppapi/c/ppb_messaging.h ../native_client/src/third_party/ppapi/c/ppb_url_loader.h ../native_client/src/third_party/ppapi/c/ppb_url_request_info.h ../native_client/src/third_party/ppapi/c/ppb_url_response_info.h ../native_client/src/third_party/ppapi/c/ppb_var.h ../native_client/src/third_party/ppapi/c/ppp.h ../native_client/src/third_party/ppapi/c/ppp_input_event.h ../native_client/src/third_party/ppapi/c/ppp_instance.h ../native_client/src/third_party/ppapi/c/ppp_messaging.h ../native_client/src/third_party/ppapi/c/private/ppb_pdf.h ../native_client/src/third_party/ppapi/c/trusted/ppb_image_data_trusted.h ../native_client/src/third_party/ppapi/cpp/core.h ../native_client/src/third_party/ppapi/cpp/module.h ../native_client/src/third_party/ppapi/cpp/module_impl.h ../native_client/src/third_party/valgrind/memcheck.h ../native_client/src/third_party/valgrind/valgrind.h ../native_client/src/trusted/desc/nacl_desc_base.h ../native_client/src/trusted/desc/nacl_desc_effector.h ../native_client/src/trusted/desc/nacl_desc_imc.h ../native_client/src/trusted/desc/nrd_xfer.h ../native_client/src/trusted/desc/nrd_xfer_effector.h ../native_client/src/trusted/nacl_base/nacl_refcount.h ../native_client/src/trusted/service_runtime/include/bits/nacl_imc_api.h ../native_client/src/trusted/service_runtime/include/bits/nacl_syscalls.h ../native_client/src/trusted/service_runtime/include/bits/wordsize.h ../native_client/src/trusted/service_runtime/include/machine/_types.h ../native_client/src/trusted/service_runtime/include/sys/errno.h ../native_client/src/trusted/service_runtime/include/sys/nacl_imc_api.h ../native_client/src/trusted/service_runtime/include/sys/nacl_kern_rpc.h ../native_client/src/trusted/service_runtime/include/sys/nacl_syscalls.h ../native_client/src/trusted/service_runtime/include/sys/time.h ../native_client/src/trusted/service_runtime/nacl_config.h ../native_client/src/untrusted/irt/irt.h ../native_client/src/untrusted/irt/irt_basic.c ../native_client/src/untrusted/irt/irt_blockhook.c ../native_client/src/untrusted/irt/irt_cond.c ../native_client/src/untrusted/irt/irt_dyncode.c ../native_client/src/untrusted/irt/irt_entry.c ../native_client/src/untrusted/irt/irt_entry_ppapi.c ../native_client/src/untrusted/irt/irt_fdio.c ../native_client/src/untrusted/irt/irt_filename.c ../native_client/src/untrusted/irt/irt_interfaces.c ../native_client/src/untrusted/irt/irt_interfaces.h ../native_client/src/untrusted/irt/irt_interfaces_ppapi.c ../native_client/src/untrusted/irt/irt_malloc.c ../native_client/src/untrusted/irt/irt_manifest.c ../native_client/src/untrusted/irt/irt_memory.c ../native_client/src/untrusted/irt/irt_mutex.c ../native_client/src/untrusted/irt/irt_ppapi.c ../native_client/src/untrusted/irt/irt_ppapi.h ../native_client/src/untrusted/irt/irt_private.h ../native_client/src/untrusted/irt/irt_private_pthread.c ../native_client/src/untrusted/irt/irt_private_tls.c ../native_client/src/untrusted/irt/irt_sem.c ../native_client/src/untrusted/irt/irt_thread.c ../native_client/src/untrusted/irt/irt_tls.c ../native_client/src/untrusted/nacl/_exit.c ../native_client/src/untrusted/nacl/clock.c ../native_client/src/untrusted/nacl/close.c ../native_client/src/untrusted/nacl/dup.c ../native_client/src/untrusted/nacl/fstat.c ../native_client/src/untrusted/nacl/gc_hooks.c ../native_client/src/untrusted/nacl/gc_hooks.h ../native_client/src/untrusted/nacl/getdents.c ../native_client/src/untrusted/nacl/getpid.c ../native_client/src/untrusted/nacl/gettimeofday.c ../native_client/src/untrusted/nacl/imc_accept.c ../native_client/src/untrusted/nacl/imc_connect.c ../native_client/src/untrusted/nacl/imc_makeboundsock.c ../native_client/src/untrusted/nacl/imc_mem_obj_create.c ../native_client/src/untrusted/nacl/imc_recvmsg.c ../native_client/src/untrusted/nacl/imc_sendmsg.c ../native_client/src/untrusted/nacl/imc_socketpair.c ../native_client/src/untrusted/nacl/lock.c ../native_client/src/untrusted/nacl/lseek.c ../native_client/src/untrusted/nacl/mmap.c ../native_client/src/untrusted/nacl/munmap.c ../native_client/src/untrusted/nacl/nacl_irt.c ../native_client/src/untrusted/nacl/nacl_irt.h ../native_client/src/untrusted/nacl/nacl_read_tp.c ../native_client/src/untrusted/nacl/nacl_startup.h ../native_client/src/untrusted/nacl/nacl_thread.h ../native_client/src/untrusted/nacl/nacl_tls_get.c ../native_client/src/untrusted/nacl/nacl_tls_init.c ../native_client/src/untrusted/nacl/nameservice.c ../native_client/src/untrusted/nacl/nanosleep.c ../native_client/src/untrusted/nacl/open.c ../native_client/src/untrusted/nacl/pthread_initialize_minimal.c ../native_client/src/untrusted/nacl/pthread_stubs.c ../native_client/src/untrusted/nacl/read.c ../native_client/src/untrusted/nacl/sbrk.c ../native_client/src/untrusted/nacl/sched_yield.c ../native_client/src/untrusted/nacl/stacktrace.c ../native_client/src/untrusted/nacl/start.c ../native_client/src/untrusted/nacl/stat.c ../native_client/src/untrusted/nacl/sys_private.c ../native_client/src/untrusted/nacl/syscall_bindings_trampoline.h ../native_client/src/untrusted/nacl/sysconf.c ../native_client/src/untrusted/nacl/tls.c ../native_client/src/untrusted/nacl/tls.h ../native_client/src/untrusted/nacl/tls_params.h ../native_client/src/untrusted/nacl/write.c ../native_client/src/untrusted/pthread/nc_condvar.c ../native_client/src/untrusted/pthread/nc_hash.h ../native_client/src/untrusted/pthread/nc_mutex.c ../native_client/src/untrusted/pthread/nc_token.c ../native_client/src/untrusted/pthread/nc_tsd.c ../native_client/src/untrusted/pthread/pthread.h ../native_client/src/untrusted/pthread/pthread_internal.h ../native_client/src/untrusted/pthread/pthread_types.h ../native_client/src/untrusted/pthread/semaphore.h ../native_client/src/untrusted/stubs/crt1.x ../native_client/src/untrusted/stubs/crti_x86_32.S ../native_client/src/untrusted/stubs/crti_x86_64.S ../native_client/src/untrusted/stubs/crtn_x86_32.S ../native_client/src/untrusted/stubs/crtn_x86_64.S ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-ar ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-g++ ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-gcc ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-ranlib On Thu, Aug 18, 2011 at 12:11 PM, <noelallen@google.com> wrote: > LGTM+ > > Feel free to split the action into three cases if you feel it's worth it, > otherwise it's fine as is. > > > http://codereview.chromium.**org/7669058/diff/2001/chrome/**nacl.gypi<http://... > File chrome/nacl.gypi (right): > > http://codereview.chromium.**org/7669058/diff/2001/chrome/** > nacl.gypi#newcode98<http://codereview.chromium.org/7669058/diff/2001/chrome/nacl.gypi#newcode98> > chrome/nacl.gypi:98: 'action': [ > I've never seen the case of appending to an action? > > > http://codereview.chromium.**org/7669058/<http://codereview.chromium.org/7669... >
LGTM to the extent I understand it.
Oh, there's an issue with scons's underlays. Here's a more correct list: ../base/at_exit.h ../base/atomic_ref_count.h ../base/atomicops.h ../base/atomicops_internals_arm_gcc.h ../base/atomicops_internals_atomicword_compat.h ../base/atomicops_internals_x86_gcc.h ../base/atomicops_internals_x86_macosx.h ../base/atomicops_internals_x86_msvc.h ../base/base_export.h ../base/basictypes.h ../base/callback.h ../base/callback_internal.h ../base/command_line.h ../base/compiler_specific.h ../base/debug/alias.h ../base/debug/trace_event.h ../base/hash_tables.h ../base/logging.h ../base/memory/raw_scoped_refptr_mismatch_checker.h ../base/memory/ref_counted.h ../base/memory/scoped_ptr.h ../base/memory/singleton.h ../base/memory/weak_ptr.h ../base/port.h ../base/string16.h ../base/string_piece.h ../base/string_util.h ../base/string_util_posix.h ../base/string_util_win.h ../base/synchronization/lock.h ../base/synchronization/lock_impl.h ../base/task.h ../base/template_util.h ../base/third_party/dynamic_annotations/dynamic_annotations.h ../base/threading/platform_thread.h ../base/threading/thread_checker.h ../base/threading/thread_checker_impl.h ../base/threading/thread_collision_warner.h ../base/threading/thread_restrictions.h ../base/time.h ../base/timer.h ../base/tracked.h ../base/tuple.h ../build/build_config.h ../gpu/GLES2/gl2.h ../gpu/GLES2/gl2ext.h ../gpu/GLES2/gl2platform.h ../gpu/KHR/khrplatform.h ../gpu/command_buffer/client/cmd_buffer_helper.cc ../gpu/command_buffer/client/cmd_buffer_helper.h ../gpu/command_buffer/client/fenced_allocator.cc ../gpu/command_buffer/client/fenced_allocator.h ../gpu/command_buffer/client/gles2_c_lib.cc ../gpu/command_buffer/client/gles2_c_lib_autogen.h ../gpu/command_buffer/client/gles2_cmd_helper.cc ../gpu/command_buffer/client/gles2_cmd_helper.h ../gpu/command_buffer/client/gles2_cmd_helper_autogen.h ../gpu/command_buffer/client/gles2_implementation.cc ../gpu/command_buffer/client/gles2_implementation.h ../gpu/command_buffer/client/gles2_implementation_autogen.h ../gpu/command_buffer/client/gles2_lib.cc ../gpu/command_buffer/client/gles2_lib.h ../gpu/command_buffer/client/mapped_memory.cc ../gpu/command_buffer/client/mapped_memory.h ../gpu/command_buffer/client/program_info_manager.cc ../gpu/command_buffer/client/program_info_manager.h ../gpu/command_buffer/client/ring_buffer.cc ../gpu/command_buffer/client/ring_buffer.h ../gpu/command_buffer/common/bitfield_helpers.h ../gpu/command_buffer/common/buffer.h ../gpu/command_buffer/common/cmd_buffer_common.cc ../gpu/command_buffer/common/cmd_buffer_common.h ../gpu/command_buffer/common/command_buffer.h ../gpu/command_buffer/common/constants.h ../gpu/command_buffer/common/gles2_cmd_format.cc ../gpu/command_buffer/common/gles2_cmd_format.h ../gpu/command_buffer/common/gles2_cmd_format_autogen.h ../gpu/command_buffer/common/gles2_cmd_ids.h ../gpu/command_buffer/common/gles2_cmd_ids_autogen.h ../gpu/command_buffer/common/gles2_cmd_utils.cc ../gpu/command_buffer/common/gles2_cmd_utils.h ../gpu/command_buffer/common/gles2_cmd_utils_autogen.h ../gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h ../gpu/command_buffer/common/id_allocator.cc ../gpu/command_buffer/common/id_allocator.h ../gpu/command_buffer/common/logging.h ../gpu/command_buffer/common/scoped_ptr.h ../gpu/command_buffer/common/thread_local.h ../gpu/command_buffer/common/trace_event.h ../gpu/command_buffer/common/types.h ../native_client/src/include/atomic_ops.h ../native_client/src/include/checked_cast.h ../native_client/src/include/elf32.h ../native_client/src/include/elf_auxv.h ../native_client/src/include/elf_constants.h ../native_client/src/include/linux/arm/atomic_ops.h ../native_client/src/include/linux/x86/atomic_ops.h ../native_client/src/include/nacl/atomic_ops.h ../native_client/src/include/nacl/nacl_inttypes.h ../native_client/src/include/nacl_asm.h ../native_client/src/include/nacl_assert.h ../native_client/src/include/nacl_base.h ../native_client/src/include/nacl_compiler_annotations.h ../native_client/src/include/nacl_macros.h ../native_client/src/include/nacl_memory.h ../native_client/src/include/nacl_scoped_ptr.h ../native_client/src/include/osx/atomic_ops_osx.h ../native_client/src/include/portability.h ../native_client/src/include/portability_io.h ../native_client/src/include/portability_process.h ../native_client/src/include/portability_string.h ../native_client/src/include/ref_counted.h ../native_client/src/include/win/atomic_ops_win32.h ../native_client/src/include/win/port_win.h ../native_client/src/shared/gio/gio.c ../native_client/src/shared/gio/gio.h ../native_client/src/shared/gio/gio_mem.c ../native_client/src/shared/gio/gio_mem_snapshot.c ../native_client/src/shared/gio/gprintf.c ../native_client/src/shared/imc/nacl_imc_c.h ../native_client/src/shared/platform/linux/condition_variable.c ../native_client/src/shared/platform/linux/lock.c ../native_client/src/shared/platform/linux/nacl_exit.c ../native_client/src/shared/platform/linux/nacl_host_desc_types.h ../native_client/src/shared/platform/linux/nacl_thread_id.c ../native_client/src/shared/platform/linux/nacl_threads.c ../native_client/src/shared/platform/linux/nacl_threads_types.h ../native_client/src/shared/platform/linux/nacl_timestamp.c ../native_client/src/shared/platform/nacl_check.c ../native_client/src/shared/platform/nacl_check.h ../native_client/src/shared/platform/nacl_exit.h ../native_client/src/shared/platform/nacl_host_desc.h ../native_client/src/shared/platform/nacl_log.c ../native_client/src/shared/platform/nacl_log.h ../native_client/src/shared/platform/nacl_log_intern.h ../native_client/src/shared/platform/nacl_sync.h ../native_client/src/shared/platform/nacl_sync_checked.c ../native_client/src/shared/platform/nacl_sync_checked.h ../native_client/src/shared/platform/nacl_threads.h ../native_client/src/shared/platform/nacl_timestamp.h ../native_client/src/shared/platform/refcount_base.cc ../native_client/src/shared/platform/refcount_base.h ../native_client/src/shared/platform/win/nacl_host_desc_types.h ../native_client/src/shared/platform/win/nacl_threads_types.h ../native_client/src/shared/ppapi_proxy/browser_globals.h ../native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc ../native_client/src/shared/ppapi_proxy/command_buffer_nacl.h ../native_client/src/shared/ppapi_proxy/input_event_data.cc ../native_client/src/shared/ppapi_proxy/input_event_data.h ../native_client/src/shared/ppapi_proxy/object_serialize.cc ../native_client/src/shared/ppapi_proxy/object_serialize.h ../native_client/src/shared/ppapi_proxy/plugin_callback.cc ../native_client/src/shared/ppapi_proxy/plugin_callback.h ../native_client/src/shared/ppapi_proxy/plugin_context_3d.cc ../native_client/src/shared/ppapi_proxy/plugin_context_3d.h ../native_client/src/shared/ppapi_proxy/plugin_globals.cc ../native_client/src/shared/ppapi_proxy/plugin_globals.h ../native_client/src/shared/ppapi_proxy/plugin_instance_data.cc ../native_client/src/shared/ppapi_proxy/plugin_instance_data.h ../native_client/src/shared/ppapi_proxy/plugin_main.cc ../native_client/src/shared/ppapi_proxy/plugin_nacl_file.cc ../native_client/src/shared/ppapi_proxy/plugin_nacl_file.h ../native_client/src/shared/ppapi_proxy/plugin_opengles.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio_config.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_audio_config.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_core.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_core.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_cursor_control.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_cursor_control.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_ref.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_ref.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_system.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_file_system.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_find.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_find.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_font.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_font.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_2d.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_2d.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_input_event.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_input_event.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_instance.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_instance.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_memory.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_memory.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_messaging.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_messaging.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_pdf.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_testing.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_testing.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_loader.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_loader.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_request_info.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_request_info.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_response_info.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_url_response_info.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_var.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_var.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_widget.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_widget.h ../native_client/src/shared/ppapi_proxy/plugin_ppb_zoom.cc ../native_client/src/shared/ppapi_proxy/plugin_ppb_zoom.h ../native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_input_event_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_instance_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_messaging_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_printing_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_scrollbar_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_widget_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_ppp_zoom_rpc_server.cc ../native_client/src/shared/ppapi_proxy/plugin_resource.cc ../native_client/src/shared/ppapi_proxy/plugin_resource.h ../native_client/src/shared/ppapi_proxy/plugin_resource_tracker.cc ../native_client/src/shared/ppapi_proxy/plugin_resource_tracker.h ../native_client/src/shared/ppapi_proxy/plugin_surface_3d.cc ../native_client/src/shared/ppapi_proxy/plugin_surface_3d.h ../native_client/src/shared/ppapi_proxy/plugin_threading.cc ../native_client/src/shared/ppapi_proxy/plugin_upcall.cc ../native_client/src/shared/ppapi_proxy/plugin_upcall.h ../native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc ../native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc ../native_client/src/shared/ppapi_proxy/ppruntime.h ../native_client/src/shared/ppapi_proxy/proxy_var.cc ../native_client/src/shared/ppapi_proxy/proxy_var.h ../native_client/src/shared/ppapi_proxy/proxy_var_cache.cc ../native_client/src/shared/ppapi_proxy/proxy_var_cache.h ../native_client/src/shared/ppapi_proxy/string_proxy_var.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h ../native_client/src/shared/ppapi_proxy/untrusted/srpcgen/upcall.h ../native_client/src/shared/ppapi_proxy/upcall_client.cc ../native_client/src/shared/ppapi_proxy/utility.cc ../native_client/src/shared/ppapi_proxy/utility.h ../native_client/src/shared/srpc/accept.c ../native_client/src/shared/srpc/accept_threaded.c ../native_client/src/shared/srpc/invoke.c ../native_client/src/shared/srpc/module_init_fini.c ../native_client/src/shared/srpc/nacl_srpc.c ../native_client/src/shared/srpc/nacl_srpc.h ../native_client/src/shared/srpc/nacl_srpc_internal.h ../native_client/src/shared/srpc/nacl_srpc_message.c ../native_client/src/shared/srpc/nacl_srpc_message.h ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_init.c ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_internal.c ../native_client/src/shared/srpc/nacl_srpc_ppapi_plugin_internal.h ../native_client/src/shared/srpc/rpc_log.c ../native_client/src/shared/srpc/rpc_serialize.c ../native_client/src/shared/srpc/rpc_server_loop.c ../native_client/src/shared/srpc/rpc_service.c ../native_client/src/third_party/dlmalloc/malloc.c ../native_client/src/third_party/ppapi/c/dev/deprecated_bool.h ../native_client/src/third_party/ppapi/c/dev/pp_cursor_type_dev.h ../native_client/src/third_party/ppapi/c/dev/pp_graphics_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_buffer_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_context_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_context_3d_trusted_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_cursor_control_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_find_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_font_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_memory_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_opengles_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_scrollbar_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_surface_3d_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_testing_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_var_deprecated.h ../native_client/src/third_party/ppapi/c/dev/ppb_widget_dev.h ../native_client/src/third_party/ppapi/c/dev/ppb_zoom_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_find_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_printing_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_scrollbar_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_selection_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_widget_dev.h ../native_client/src/third_party/ppapi/c/dev/ppp_zoom_dev.h ../native_client/src/third_party/ppapi/c/pp_bool.h ../native_client/src/third_party/ppapi/c/pp_completion_callback.h ../native_client/src/third_party/ppapi/c/pp_errors.h ../native_client/src/third_party/ppapi/c/pp_file_info.h ../native_client/src/third_party/ppapi/c/pp_input_event.h ../native_client/src/third_party/ppapi/c/pp_instance.h ../native_client/src/third_party/ppapi/c/pp_macros.h ../native_client/src/third_party/ppapi/c/pp_module.h ../native_client/src/third_party/ppapi/c/pp_point.h ../native_client/src/third_party/ppapi/c/pp_rect.h ../native_client/src/third_party/ppapi/c/pp_resource.h ../native_client/src/third_party/ppapi/c/pp_size.h ../native_client/src/third_party/ppapi/c/pp_stdint.h ../native_client/src/third_party/ppapi/c/pp_time.h ../native_client/src/third_party/ppapi/c/pp_var.h ../native_client/src/third_party/ppapi/c/ppb.h ../native_client/src/third_party/ppapi/c/ppb_audio.h ../native_client/src/third_party/ppapi/c/ppb_audio_config.h ../native_client/src/third_party/ppapi/c/ppb_core.h ../native_client/src/third_party/ppapi/c/ppb_file_io.h ../native_client/src/third_party/ppapi/c/ppb_file_ref.h ../native_client/src/third_party/ppapi/c/ppb_file_system.h ../native_client/src/third_party/ppapi/c/ppb_graphics_2d.h ../native_client/src/third_party/ppapi/c/ppb_image_data.h ../native_client/src/third_party/ppapi/c/ppb_input_event.h ../native_client/src/third_party/ppapi/c/ppb_instance.h ../native_client/src/third_party/ppapi/c/ppb_messaging.h ../native_client/src/third_party/ppapi/c/ppb_url_loader.h ../native_client/src/third_party/ppapi/c/ppb_url_request_info.h ../native_client/src/third_party/ppapi/c/ppb_url_response_info.h ../native_client/src/third_party/ppapi/c/ppb_var.h ../native_client/src/third_party/ppapi/c/ppp.h ../native_client/src/third_party/ppapi/c/ppp_input_event.h ../native_client/src/third_party/ppapi/c/ppp_instance.h ../native_client/src/third_party/ppapi/c/ppp_messaging.h ../native_client/src/third_party/ppapi/c/private/ppb_pdf.h ../native_client/src/third_party/ppapi/c/trusted/ppb_image_data_trusted.h ../native_client/src/third_party/ppapi/cpp/core.h ../native_client/src/third_party/ppapi/cpp/module.h ../native_client/src/third_party/ppapi/cpp/module_impl.h ../native_client/src/third_party/valgrind/memcheck.h ../native_client/src/third_party/valgrind/valgrind.h ../native_client/src/trusted/desc/nacl_desc_base.h ../native_client/src/trusted/desc/nacl_desc_effector.h ../native_client/src/trusted/desc/nacl_desc_imc.h ../native_client/src/trusted/desc/nrd_xfer.h ../native_client/src/trusted/desc/nrd_xfer_effector.h ../native_client/src/trusted/nacl_base/nacl_refcount.h ../native_client/src/trusted/service_runtime/include/bits/nacl_imc_api.h ../native_client/src/trusted/service_runtime/include/bits/nacl_syscalls.h ../native_client/src/trusted/service_runtime/include/bits/wordsize.h ../native_client/src/trusted/service_runtime/include/machine/_types.h ../native_client/src/trusted/service_runtime/include/sys/errno.h ../native_client/src/trusted/service_runtime/include/sys/nacl_imc_api.h ../native_client/src/trusted/service_runtime/include/sys/nacl_kern_rpc.h ../native_client/src/trusted/service_runtime/include/sys/nacl_syscalls.h ../native_client/src/trusted/service_runtime/include/sys/time.h ../native_client/src/trusted/service_runtime/nacl_config.h ../native_client/src/untrusted/irt/irt.h ../native_client/src/untrusted/irt/irt_basic.c ../native_client/src/untrusted/irt/irt_blockhook.c ../native_client/src/untrusted/irt/irt_cond.c ../native_client/src/untrusted/irt/irt_dyncode.c ../native_client/src/untrusted/irt/irt_entry.c ../native_client/src/untrusted/irt/irt_entry_ppapi.c ../native_client/src/untrusted/irt/irt_fdio.c ../native_client/src/untrusted/irt/irt_filename.c ../native_client/src/untrusted/irt/irt_interfaces.c ../native_client/src/untrusted/irt/irt_interfaces.h ../native_client/src/untrusted/irt/irt_interfaces_ppapi.c ../native_client/src/untrusted/irt/irt_malloc.c ../native_client/src/untrusted/irt/irt_manifest.c ../native_client/src/untrusted/irt/irt_memory.c ../native_client/src/untrusted/irt/irt_mutex.c ../native_client/src/untrusted/irt/irt_ppapi.c ../native_client/src/untrusted/irt/irt_ppapi.h ../native_client/src/untrusted/irt/irt_private.h ../native_client/src/untrusted/irt/irt_private_pthread.c ../native_client/src/untrusted/irt/irt_private_tls.c ../native_client/src/untrusted/irt/irt_sem.c ../native_client/src/untrusted/irt/irt_thread.c ../native_client/src/untrusted/irt/irt_tls.c ../native_client/src/untrusted/nacl/_exit.c ../native_client/src/untrusted/nacl/clock.c ../native_client/src/untrusted/nacl/close.c ../native_client/src/untrusted/nacl/dup.c ../native_client/src/untrusted/nacl/fstat.c ../native_client/src/untrusted/nacl/gc_hooks.c ../native_client/src/untrusted/nacl/gc_hooks.h ../native_client/src/untrusted/nacl/getdents.c ../native_client/src/untrusted/nacl/getpid.c ../native_client/src/untrusted/nacl/gettimeofday.c ../native_client/src/untrusted/nacl/imc_accept.c ../native_client/src/untrusted/nacl/imc_connect.c ../native_client/src/untrusted/nacl/imc_makeboundsock.c ../native_client/src/untrusted/nacl/imc_mem_obj_create.c ../native_client/src/untrusted/nacl/imc_recvmsg.c ../native_client/src/untrusted/nacl/imc_sendmsg.c ../native_client/src/untrusted/nacl/imc_socketpair.c ../native_client/src/untrusted/nacl/lock.c ../native_client/src/untrusted/nacl/lseek.c ../native_client/src/untrusted/nacl/mmap.c ../native_client/src/untrusted/nacl/munmap.c ../native_client/src/untrusted/nacl/nacl_irt.c ../native_client/src/untrusted/nacl/nacl_irt.h ../native_client/src/untrusted/nacl/nacl_read_tp.c ../native_client/src/untrusted/nacl/nacl_startup.h ../native_client/src/untrusted/nacl/nacl_thread.h ../native_client/src/untrusted/nacl/nacl_tls_get.c ../native_client/src/untrusted/nacl/nacl_tls_init.c ../native_client/src/untrusted/nacl/nameservice.c ../native_client/src/untrusted/nacl/nanosleep.c ../native_client/src/untrusted/nacl/open.c ../native_client/src/untrusted/nacl/pthread_initialize_minimal.c ../native_client/src/untrusted/nacl/pthread_stubs.c ../native_client/src/untrusted/nacl/read.c ../native_client/src/untrusted/nacl/sbrk.c ../native_client/src/untrusted/nacl/sched_yield.c ../native_client/src/untrusted/nacl/stacktrace.c ../native_client/src/untrusted/nacl/start.c ../native_client/src/untrusted/nacl/stat.c ../native_client/src/untrusted/nacl/sys_private.c ../native_client/src/untrusted/nacl/syscall_bindings_trampoline.h ../native_client/src/untrusted/nacl/sysconf.c ../native_client/src/untrusted/nacl/tls.c ../native_client/src/untrusted/nacl/tls.h ../native_client/src/untrusted/nacl/tls_params.h ../native_client/src/untrusted/nacl/write.c ../native_client/src/untrusted/pthread/nc_condvar.c ../native_client/src/untrusted/pthread/nc_hash.h ../native_client/src/untrusted/pthread/nc_mutex.c ../native_client/src/untrusted/pthread/nc_token.c ../native_client/src/untrusted/pthread/nc_tsd.c ../native_client/src/untrusted/pthread/pthread.h ../native_client/src/untrusted/pthread/pthread_internal.h ../native_client/src/untrusted/pthread/pthread_types.h ../native_client/src/untrusted/pthread/semaphore.h ../native_client/src/untrusted/stubs/crt1.x ../native_client/src/untrusted/stubs/crti_x86_32.S ../native_client/src/untrusted/stubs/crti_x86_64.S ../native_client/src/untrusted/stubs/crtn_x86_32.S ../native_client/src/untrusted/stubs/crtn_x86_64.S ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-ar ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-g++ ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-gcc ../native_client/toolchain/mac_x86_newlib/bin/x86_64-nacl-ranlib ../ui/gfx/gl/gl_switches.h On Thu, Aug 18, 2011 at 12:27 PM, <brettw@chromium.org> wrote: > LGTM to the extent I understand it. > > > http://codereview.chromium.**org/7669058/<http://codereview.chromium.org/7669... >
Hi Brad, since this is "step N of many", do you think it's worth to have a tracking bug you assign all these CLs to? Thanks, Nico
Excellent point :-). Brett / Noel, did you guys have anything filed, I wasn't able to find anything obvious? -BradN On Fri, Aug 19, 2011 at 8:56 AM, <thakis@chromium.org> wrote: > Hi Brad, > > since this is "step N of many", do you think it's worth to have a tracking > bug > you assign all these CLs to? > > Thanks, > Nico > > > http://codereview.chromium.**org/7669058/<http://codereview.chromium.org/7669... >
Filed as: Cr bug #93520 On Fri, Aug 19, 2011 at 8:59 AM, Bradley Nelson <bradnelson@google.com> wrote: > Excellent point :-). > Brett / Noel, did you guys have anything filed, I wasn't able to find > anything obvious? > -BradN > On Fri, Aug 19, 2011 at 8:56 AM, <thakis@chromium.org> wrote: >> >> Hi Brad, >> >> since this is "step N of many", do you think it's worth to have a tracking >> bug >> you assign all these CLs to? >> >> Thanks, >> Nico >> >> http://codereview.chromium.org/7669058/ > > |