Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 7669058: Switching IRT to be built inside the chrome build. (Closed)

Created:
9 years, 4 months ago by bradn
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Switching IRT to be built inside the chrome build. Dropping the IRT download step from the DEPS. Step3 of a many step plan to switch where ppapi + irt live / are built. BUG=None TEST=None R=noelallen@google.com,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97429

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -44 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +10 lines, -23 lines 0 comments Download
A chrome/build_nacl_irt.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +164 lines, -0 lines 0 comments Download
M chrome/nacl.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +46 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bradn
9 years, 4 months ago (2011-08-18 18:44:12 UTC) #1
noelallen_use_chromium
LGTM+ Feel free to split the action into three cases if you feel it's worth ...
9 years, 4 months ago (2011-08-18 19:11:16 UTC) #2
bradn
Oh, here's the list of inputs: ../base/at_exit.h ../base/atomic_ref_count.h ../base/atomicops.h ../base/atomicops_internals_arm_gcc.h ../base/atomicops_internals_atomicword_compat.h ../base/atomicops_internals_x86_gcc.h ../base/atomicops_internals_x86_macosx.h ../base/atomicops_internals_x86_msvc.h ../base/base_export.h ...
9 years, 4 months ago (2011-08-18 19:26:44 UTC) #3
brettw
LGTM to the extent I understand it.
9 years, 4 months ago (2011-08-18 19:27:11 UTC) #4
bradn
Oh, there's an issue with scons's underlays. Here's a more correct list: ../base/at_exit.h ../base/atomic_ref_count.h ../base/atomicops.h ...
9 years, 4 months ago (2011-08-18 20:11:05 UTC) #5
Nico
Hi Brad, since this is "step N of many", do you think it's worth to ...
9 years, 4 months ago (2011-08-19 15:56:27 UTC) #6
bradn
Excellent point :-). Brett / Noel, did you guys have anything filed, I wasn't able ...
9 years, 4 months ago (2011-08-19 15:59:10 UTC) #7
noelallen_use_chromium
9 years, 4 months ago (2011-08-19 18:33:09 UTC) #8
Filed as: Cr bug #93520

On Fri, Aug 19, 2011 at 8:59 AM, Bradley Nelson <bradnelson@google.com> wrote:
> Excellent point :-).
> Brett / Noel, did you guys have anything filed, I wasn't able to find
> anything obvious?
> -BradN
> On Fri, Aug 19, 2011 at 8:56 AM, <thakis@chromium.org> wrote:
>>
>> Hi Brad,
>>
>> since this is "step N of many", do you think it's worth to have a tracking
>> bug
>> you assign all these CLs to?
>>
>> Thanks,
>> Nico
>>
>> http://codereview.chromium.org/7669058/
>
>

Powered by Google App Engine
This is Rietveld 408576698