Switching IRT to be built inside the chrome build.

Switching NaCl IRT to be built inside the chrome build.

Third attempt:

Switching IRT to be built inside the chrome build. Dropping the IRT download
step from the DEPS. Step3 of a many step plan to switch where ppapi + irt
are built.
Dropping download_nacl_irt because we no longer rely on a prebuilt copy.
Dropping irt download drop source tarball (assume people using it will have
to download / build their own nacl toolchain).

Old Review URL: http://codereview.chromium.org/7669058

R=noelallen@google.com
BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97943

[noelallen_use_chromium, 2011-08-23 21:42:05]

Please also add BUG#

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:5: 
Clean out plz.

[noelallen_use_chromium, 2011-08-23 21:42:15]

LGTM after nits.

[Mark Seaborn, 2011-08-23 21:42:21]

http://codereview.chromium.org/7685042/diff/5002/DEPS
File DEPS (right):

http://codereview.chromium.org/7685042/diff/5002/DEPS#newcode27
DEPS:27: "nacl_toolchain_revision": "6494",
Do I need to update nacl_deps_bump.py to update this?

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:6: #import sys
Don't forget to remove this.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:134: # a process is not the primary owner of a terminal
on OSX.
"not a member of a foreground job on a tty"?

e.g. On a Mac:

hydric:test mseaborn$ python -c 'import readline' &
[1] 67058
hydric:test mseaborn$ 
[1]+  Stopped                 python -c 'import readline'

i.e. the process receives a stop signal when it's a background job.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:136: devnull = open(os.devnull, 'rb').fileno()
open(os.devnull, 'rb').fileno() is wrong: the file object will probably get GC'd
and the file will be closed.

open(os.devnull, 'rb') will work: subprocess accepts file objects.

No need for the 'b' flag on Unix.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:139: p = subprocess.Popen(cmd, cwd=NACL_DIR,
stdin=devnull)
Use either cwd= or chdir() but not both?

[bradn, 2011-08-23 21:53:48]

PTAL

http://codereview.chromium.org/7685042/diff/5002/DEPS
File DEPS (right):

http://codereview.chromium.org/7685042/diff/5002/DEPS#newcode27
DEPS:27: "nacl_toolchain_revision": "6494",
On 2011/08/23 21:42:21, Mark Seaborn wrote:
> Do I need to update nacl_deps_bump.py to update this?

Ideally yes, perhaps, though once we move where the ppapi stuff comes from,
presumably we might not always bump the toolchain? dunno.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:5: 
On 2011/08/23 21:42:05, noelallen wrote:
> Clean out plz.

Done.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:6: #import sys
On 2011/08/23 21:42:21, Mark Seaborn wrote:
> Don't forget to remove this.

Done.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:134: # a process is not the primary owner of a terminal
on OSX.
On 2011/08/23 21:42:21, Mark Seaborn wrote:
> "not a member of a foreground job on a tty"?
> 
> e.g. On a Mac:
> 
> hydric:test mseaborn$ python -c 'import readline' &
> [1] 67058
> hydric:test mseaborn$ 
> [1]+  Stopped                 python -c 'import readline'
> 
> i.e. the process receives a stop signal when it's a background job.

Done.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:136: devnull = open(os.devnull, 'rb').fileno()
On 2011/08/23 21:42:21, Mark Seaborn wrote:
> open(os.devnull, 'rb').fileno() is wrong: the file object will probably get
GC'd
> and the file will be closed.
> 
> open(os.devnull, 'rb') will work: subprocess accepts file objects.
> 
> No need for the 'b' flag on Unix.

Done.

http://codereview.chromium.org/7685042/diff/5002/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:139: p = subprocess.Popen(cmd, cwd=NACL_DIR,
stdin=devnull)
On 2011/08/23 21:42:21, Mark Seaborn wrote:
> Use either cwd= or chdir() but not both?

Done.