Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 7715005: Changed all @code to <code> and @endcode to </code> as per dmichael (Closed)

Created:
9 years, 4 months ago by jond
Modified:
9 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Changed all @code to <code> and @endcode to </code> as per dmichael. Adding Polina to the review to look at url_loader.h and give approval of text that points to example. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98856

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 17

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -211 lines) Patch
M ppapi/api/ppb_audio.idl View 1 2 3 4 5 6 7 5 chunks +55 lines, -43 lines 0 comments Download
M ppapi/api/ppb_audio_config.idl View 1 2 3 4 5 6 7 5 chunks +14 lines, -9 lines 0 comments Download
M ppapi/api/ppb_messaging.idl View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/api/ppp_messaging.idl View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/ppb_audio.h View 1 2 3 4 5 6 7 5 chunks +56 lines, -44 lines 0 comments Download
M ppapi/c/ppb_audio_config.h View 1 2 3 4 5 6 7 6 chunks +15 lines, -10 lines 0 comments Download
M ppapi/c/ppb_messaging.h View 1 2 3 4 5 6 7 5 chunks +6 lines, -6 lines 0 comments Download
M ppapi/c/ppp_messaging.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M ppapi/cpp/audio_config.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/cpp/completion_callback.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/cpp/input_event.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/instance.h View 1 2 3 4 5 6 7 6 chunks +10 lines, -10 lines 0 comments Download
M ppapi/cpp/paint_manager.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/url_loader.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jond
9 years, 4 months ago (2011-08-23 16:47:18 UTC) #1
dmichael (off chromium)
http://codereview.chromium.org/7715005/diff/1/ppapi/c/ppb_audio_config.h File ppapi/c/ppb_audio_config.h (right): http://codereview.chromium.org/7715005/diff/1/ppapi/c/ppb_audio_config.h#newcode163 ppapi/c/ppb_audio_config.h:163: * for more on sample frame counts. Did you ...
9 years, 4 months ago (2011-08-23 16:53:52 UTC) #2
jond
http://codereview.chromium.org/7715005/diff/1/ppapi/c/ppb_audio_config.h File ppapi/c/ppb_audio_config.h (right): http://codereview.chromium.org/7715005/diff/1/ppapi/c/ppb_audio_config.h#newcode163 ppapi/c/ppb_audio_config.h:163: * for more on sample frame counts. No I ...
9 years, 4 months ago (2011-08-23 20:02:36 UTC) #3
dmichael (off chromium)
http://codereview.chromium.org/7715005/diff/6002/ppapi/api/ppb_audio.idl File ppapi/api/ppb_audio.idl (right): http://codereview.chromium.org/7715005/diff/6002/ppapi/api/ppb_audio.idl#newcode46 ppapi/api/ppb_audio.idl:46: * audio_interface</code>... missing first <code> http://codereview.chromium.org/7715005/diff/6002/ppapi/api/ppb_audio.idl#newcode72 ppapi/api/ppb_audio.idl:72: * @param[in] ...
9 years, 4 months ago (2011-08-23 20:16:11 UTC) #4
jond
http://codereview.chromium.org/7715005/diff/6002/ppapi/api/ppb_audio.idl File ppapi/api/ppb_audio.idl (right): http://codereview.chromium.org/7715005/diff/6002/ppapi/api/ppb_audio.idl#newcode46 ppapi/api/ppb_audio.idl:46: * audio_interface</code>... On 2011/08/23 20:16:11, dmichael wrote: > missing ...
9 years, 4 months ago (2011-08-23 21:15:29 UTC) #5
dmichael (off chromium)
I don't see your changes. Could you reupload please? In general, I would recommend looking ...
9 years, 4 months ago (2011-08-24 15:18:02 UTC) #6
jond
Should be there now... - Jon On Wed, Aug 24, 2011 at 9:18 AM, <dmichael@chromium.org> ...
9 years, 4 months ago (2011-08-24 15:22:05 UTC) #7
dmichael (off chromium)
Please put the audio config files together (probably in this CL makes the most sense) ...
9 years, 4 months ago (2011-08-24 15:38:01 UTC) #8
jond
http://codereview.chromium.org/7715005/diff/20/ppapi/api/ppb_audio.idl File ppapi/api/ppb_audio.idl (right): http://codereview.chromium.org/7715005/diff/20/ppapi/api/ppb_audio.idl#newcode96 ppapi/api/ppb_audio.idl:96: * @return A <code>PP_Bool</code> containing containing <code>PP_True</code> On 2011/08/24 ...
9 years, 3 months ago (2011-08-29 19:15:32 UTC) #9
dmichael (off chromium)
9 years, 3 months ago (2011-08-29 19:29:32 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld 408576698