chrome/browser/extensions/extension_tabs_module.cc - Issue 7714004: base: Add AsList() function to Value API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: OVERRIDE Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index a949b4df1de9d75d041314d9248999ed25cfe9b4..61c5eacf939b5e8a9a2e8255ec8bdcdc5d91aab2 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -417,7 +417,7 @@ bool CreateWindowFunction::RunImpl() {

std::string url_string;

url_value->GetAsString(&url_string);

url_strings.push_back(url_string);

- } else if (url_value->IsType(Value::TYPE_LIST)) {

+ } else if (url_value->AsList()) {

const ListValue* url_list = static_cast<const ListValue*>(url_value);

Evan Martin 2011/08/23 18:15:26 same transformation here (can set url_list in the

tfarina 2011/08/23 18:26:36 Done.

for (size_t i = 0; i < url_list->GetSize(); ++i) {

std::string url_string;