base: Add AsList() function to Value API.

chrome/common/json_value_serializer_unittest.cc

Index: chrome/common/json_value_serializer_unittest.cc
diff --git a/chrome/common/json_value_serializer_unittest.cc b/chrome/common/json_value_serializer_unittest.cc
index 541ac8c130c5d8e1aa18b01a04f6c040e9a59d78..94064344d025c96301cdf3303f6704ddd0e3f118 100644
--- a/chrome/common/json_value_serializer_unittest.cc
+++ b/chrome/common/json_value_serializer_unittest.cc
@@ -195,7 +195,7 @@ namespace {
 
 void ValidateJsonList(const std::string& json) {
   scoped_ptr<Value> root(base::JSONReader::Read(json, false));
-  ASSERT_TRUE(root.get() && root->IsType(Value::TYPE_LIST));
+  ASSERT_TRUE(root.get() && root->AsList());
   ListValue* list = static_cast<ListValue*>(root.get());

[Evan Martin, 2011/08/23 18:15:26]

ASSERT_TRUE(root.get());
ListValue* list = root->AsList();
ASSERT_TRUE(list)


(I know it's one more line, but I think it better conveys what's trying to be
tested and it eliminates a cast)

[tfarina, 2011/08/23 18:26:36]

Done.

   ASSERT_EQ(1U, list->GetSize());
   Value* elt = NULL;
@@ -219,7 +219,7 @@ TEST(JSONValueSerializerTest, JSONReaderComments) {
 
   // It's ok to have a comment in a string.
   root.reset(base::JSONReader::Read("[\"// ok\\n /* foo */ \"]", false));
-  ASSERT_TRUE(root.get() && root->IsType(Value::TYPE_LIST));
+  ASSERT_TRUE(root.get() && root->AsList());
   ListValue* list = static_cast<ListValue*>(root.get());
   ASSERT_EQ(1U, list->GetSize());
   Value* elt = NULL;