chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 7694014: Reland: Implement correct Panel closing sequence for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 7694014: Reland: Implement correct Panel closing sequence for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 5faefc7418f4eef97825059f7abeb76cde9ba57e..f57ebc7d3dbc58de11b5e8b6adfff0ed1ea98802 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -113,6 +113,7 @@ void BrowserWindowCocoa::Close() {

// controller) which may return |NO| causing the window to not be closed,

// thereby leaving a hidden window. In fact, our window-closing procedure

// involves a (indirect) recursion on |-performClose:|, which is also bad.

+ LOG(INFO) << "BrowserWindowCocoa::Close()";

jennb 2011/08/22 19:13:02 Did you mean to keep this debugging aid in the pat

[window() orderOut:controller_];

[window() performClose:controller_];

}