Reland: Implement correct Panel closing sequence for Mac.

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
@@ skipping 95 matching lines @@
     [controller_ deferPerformClose];
   } else {
     // Make sure we hide the window immediately. Even though performClose:
     // calls orderOut: eventually, it leaves the window on-screen long enough
     // that we start to see tabs shutting down. http://crbug.com/23959
     // TODO(viettrungluu): This is kind of bad, since |-performClose:| calls
     // |-windowShouldClose:| (on its delegate, which is probably the
     // controller) which may return |NO| causing the window to not be closed,
     // thereby leaving a hidden window. In fact, our window-closing procedure
     // involves a (indirect) recursion on |-performClose:|, which is also bad.
+    LOG(INFO) << "BrowserWindowCocoa::Close()";

[jennb, 2011/08/22 19:13:02]

Did you mean to keep this debugging aid in the patch?

     [window() orderOut:controller_];
     [window() performClose:controller_];
   }
 }
 
 void BrowserWindowCocoa::Activate() {
   [controller_ activate];
 }
 
 void BrowserWindowCocoa::Deactivate() {
@@ skipping 507 matching lines @@
 
 NSWindow* BrowserWindowCocoa::window() const {
   return [controller_ window];
 }
 
 void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) {
   if (tab_contents == browser_->GetSelectedTabContents()) {
     [controller_ updateSidebarForContents:tab_contents];
   }
 }