Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 7694014: Reland: Implement correct Panel closing sequence for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/browser_window_cocoa.mm ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/panels/panel_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 7fc539b516ee913571a187e3bcab8ffcb3765c6a..baf2e43bcba3205187adad7c523e29f4a45ee163 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -92,7 +92,13 @@ void Panel::SetBounds(const gfx::Rect& bounds) {
// close on the first attempt.
void Panel::Close() {
native_panel_->ClosePanel();
+
+// TODO(dimich): we need to only remove the panel when and if it actually
+// closes. It is now only implemented on Mac (unless it's synchronous on other
jennb 2011/08/22 19:13:02 Change the 2nd sentence to state that changes are
+// platforms).
+#if !defined(OS_MACOSX)
manager()->Remove(this);
+#endif
}
void Panel::Activate() {
« chrome/browser/ui/cocoa/browser_window_cocoa.mm ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/panels/panel_app_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698