Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 7661029: Fix handling of tab contents disappearing out from underneath Javascript dialogs. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix handling of tab contents disappearing out from underneath Javascript dialogs. BUG=93094, 90196 TEST=as in bug 93094 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97023

Patch Set 1 #

Patch Set 2 : check delegate too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/message_box_handler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 5 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Shoulda caught this during the refactor.
9 years, 4 months ago (2011-08-16 19:10:56 UTC) #1
jam
9 years, 4 months ago (2011-08-16 21:06:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698