content/browser/tab_contents/tab_contents.h - Issue 7661029: Fix handling of tab contents disappearing out from underneath Javascript dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 7661029: Fix handling of tab contents disappearing out from underneath Javascript dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: check delegate too Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tab_contents/tab_contents.h

diff --git a/content/browser/tab_contents/tab_contents.h b/content/browser/tab_contents/tab_contents.h

index 3f416e4ac8723dc76ba93ced2dff7ce573a3ee84..846fc93ba358996294014b3ad54b6c0c2f777411 100644

--- a/content/browser/tab_contents/tab_contents.h

+++ b/content/browser/tab_contents/tab_contents.h

@@ -823,6 +823,10 @@ class TabContents : public PageNavigator,

// once.

bool notify_disconnection_;

+ // Pointer to the JavaScript dialog creator, lazily assigned. Used because the

+ // delegate of this TabContents is nulled before its destructor is called.

+ content::JavaScriptDialogCreator* dialog_creator_;

#if defined(OS_WIN)

// Handle to an event that's set when the page is showing a message box (or

// equivalent constrained window). Plugin processes check this to know if

« no previous file with comments | « chrome/browser/ui/app_modal_dialogs/message_box_handler.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »