Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Unified Diff: chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h

Issue 7661029: Fix handling of tab contents disappearing out from underneath Javascript dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: check delegate too Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_modal_dialogs/message_box_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
diff --git a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
index 52510ef9aa3ffae32cdaac262982b5c3e2d307f8..788323f73eb70ef193bc44e58cb3df33ce34aa8f 100644
--- a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
+++ b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
@@ -20,7 +20,7 @@ class AppModalDialogQueue {
// Returns the singleton instance.
static AppModalDialogQueue* GetInstance();
- // Adds a modal dialog to the queue, if there are no other dialogs in the
+ // Adds a modal dialog to the queue. If there are no other dialogs in the
// queue, the dialog will be shown immediately. Once it is shown, the
// most recently active browser window (or whichever is currently active)
// will be app modal, meaning it will be activated if the user tries to
@@ -56,7 +56,8 @@ class AppModalDialogQueue {
return active_dialog_;
}
- // Iterators to walk the queue.
+ // Iterators to walk the queue. The queue does not include the currently
+ // active app modal dialog box.
typedef std::deque<AppModalDialog*>::iterator iterator;
iterator begin() {
return app_modal_dialog_queue_.begin();
@@ -81,8 +82,8 @@ class AppModalDialogQueue {
// are not valid.
AppModalDialog* GetNextDialog();
- // Contains all app modal dialogs which are waiting to be shown, with the
- // currently modal dialog at the front of the queue.
+ // Contains all app modal dialogs which are waiting to be shown. The currently
+ // active modal dialog is not included.
std::deque<AppModalDialog*> app_modal_dialog_queue_;
// The currently active app-modal dialog box's delegate. NULL if there is no
« no previous file with comments | « no previous file | chrome/browser/ui/app_modal_dialogs/message_box_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698