Issue 7646016: Remove branch in WebMediaPlayerImpl that is never reached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7646016: Remove branch in WebMediaPlayerImpl that is never reached (Closed)

Created:
9 years, 4 months ago by Alpha Left Google

Modified:
9 years, 4 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove branch in WebMediaPlayerImpl that is never reached Since bytes loaded never equal to total bytes if the resource is from http the branch is never reached and lead to confusion about the logic. This was discovered while working on other platforms. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97133

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -12 lines)			Patch
	M	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+2 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

9 years, 4 months ago (2011-08-16 18:07:00 UTC) #3

http://codereview.chromium.org/7646016/diff/1/webkit/glue/webmediaplayer_impl.cc
File webkit/glue/webmediaplayer_impl.cc (right):

http://codereview.chromium.org/7646016/diff/1/webkit/glue/webmediaplayer_impl...
webkit/glue/webmediaplayer_impl.cc:958: void
WebMediaPlayerImpl::OnNetworkEvent(PipelineStatus status) {
hmm.. I wonder if this should trigger a repaint

could be too spammy though

we have a bug where the progress bar isn't re-painting even though it's updating
(you have to wiggle the mouse over it to get it to repaint)

Expand Messages | Collapse Messages