Remove branch in WebMediaPlayerImpl that is never reached

webkit/glue/webmediaplayer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webmediaplayer_impl.h"
 
 #include <limits>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 937 matching lines @@
     case media::PIPELINE_ERROR_INVALID_STATE:
       // Decode error.
       SetNetworkState(WebMediaPlayer::DecodeError);
       break;
   }
 
   // Repaint to trigger UI update.
   Repaint();
 }
 
 void WebMediaPlayerImpl::OnNetworkEvent(PipelineStatus status) {

[scherkus (not reviewing), 2011/08/16 18:07:00]

hmm.. I wonder if this should trigger a repaint

could be too spammy though

we have a bug where the progress bar isn't re-painting even though it's updating
(you have to wiggle the mouse over it to get it to repaint)

   DCHECK(MessageLoop::current() == main_loop_);
   if (status == media::PIPELINE_OK) {
-    if (pipeline_->IsNetworkActive()) {
+    if (pipeline_->IsNetworkActive())
       SetNetworkState(WebKit::WebMediaPlayer::Loading);
-    } else {
-      // If we are inactive because we just finished receiving all the data,
-      // do one final repaint to show final progress.
-      if (bytesLoaded() == totalBytes() &&
-          network_state_ != WebKit::WebMediaPlayer::Idle) {
-        Repaint();
-
-        SetNetworkState(WebKit::WebMediaPlayer::Loaded);
-      }
-
+    else
       SetNetworkState(WebKit::WebMediaPlayer::Idle);
-    }
   }
 }
 
 void WebMediaPlayerImpl::OnDemuxerOpened() {
   DCHECK(MessageLoop::current() == main_loop_);
 
   // TODO(acolwell): Uncomment once WebKit changes are checked in.
   // https://bugs.webkit.org/show_bug.cgi?id=64731
   //GetClient()->sourceOpened();
 }
@@ skipping 42 matching lines @@
   }
 }
 
 WebKit::WebMediaPlayerClient* WebMediaPlayerImpl::GetClient() {
   DCHECK(MessageLoop::current() == main_loop_);
   DCHECK(client_);
   return client_;
 }
 
 }  // namespace webkit_glue