Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 7646016: Remove branch in WebMediaPlayerImpl that is never reached (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 76a99093b2c8c518153216cc69a39ab826d2bde8..f97ba132afe18258ef1262898279492396d65118 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -958,20 +958,10 @@ void WebMediaPlayerImpl::OnPipelineError(PipelineStatus error) {
void WebMediaPlayerImpl::OnNetworkEvent(PipelineStatus status) {
scherkus (not reviewing) 2011/08/16 18:07:00 hmm.. I wonder if this should trigger a repaint c
DCHECK(MessageLoop::current() == main_loop_);
if (status == media::PIPELINE_OK) {
- if (pipeline_->IsNetworkActive()) {
+ if (pipeline_->IsNetworkActive())
SetNetworkState(WebKit::WebMediaPlayer::Loading);
- } else {
- // If we are inactive because we just finished receiving all the data,
- // do one final repaint to show final progress.
- if (bytesLoaded() == totalBytes() &&
- network_state_ != WebKit::WebMediaPlayer::Idle) {
- Repaint();
-
- SetNetworkState(WebKit::WebMediaPlayer::Loaded);
- }
-
+ else
SetNetworkState(WebKit::WebMediaPlayer::Idle);
- }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698