Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 7640023: [ChromeOS] WebUILoginView returns true for IsPopupOrPanel. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[ChromeOS] WebUILoginView returns true for IsPopupOrPanel. This makes WebUILoginView not a drag-n-drop target as TabContents::ShouldAcceptDragAndDrop would return false now. Besides, WebUILoginView is popup in some sense. BUG=chromium-os:18781 TEST=Verify crash no longer happens for chromium-os:18781. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96636

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-12 18:29:40 UTC) #1
achuithb
LGTM with nit. http://codereview.chromium.org/7640023/diff/1/chrome/browser/chromeos/login/webui_login_view.h File chrome/browser/chromeos/login/webui_login_view.h (right): http://codereview.chromium.org/7640023/diff/1/chrome/browser/chromeos/login/webui_login_view.h#newcode113 chrome/browser/chromeos/login/webui_login_view.h:113: virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event); Also ...
9 years, 4 months ago (2011-08-12 18:34:48 UTC) #2
xiyuan
http://codereview.chromium.org/7640023/diff/1/chrome/browser/chromeos/login/webui_login_view.h File chrome/browser/chromeos/login/webui_login_view.h (right): http://codereview.chromium.org/7640023/diff/1/chrome/browser/chromeos/login/webui_login_view.h#newcode113 chrome/browser/chromeos/login/webui_login_view.h:113: virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event); On 2011/08/12 18:34:49, achuith.bhandarkar ...
9 years, 4 months ago (2011-08-12 19:32:56 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 22:19:16 UTC) #4
Change committed as 96636

Powered by Google App Engine
This is Rietveld 408576698