[ChromeOS] WebUILoginView returns true for IsPopupOrPanel.

chrome/browser/chromeos/login/webui_login_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_WEBUI_LOGIN_VIEW_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_WEBUI_LOGIN_VIEW_H_
 #pragma once
 
 #include "chrome/browser/chromeos/login/login_html_dialog.h"
 #include "chrome/browser/chromeos/status/status_area_host.h"
@@ skipping 92 matching lines @@
 
   // DOMView for rendering a webpage as a webui login.
   DOMView* webui_login_;
 
  private:
   // Map type for the accelerator-to-identifier map.
   typedef std::map<views::Accelerator, std::string> AccelMap;
 
   // Overridden from TabContentsDelegate.
   virtual bool HandleContextMenu(const ContextMenuParams& params) OVERRIDE;
+  virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);

[achuithb, 2011/08/12 18:34:49]

Also OVERRIDE?

[xiyuan, 2011/08/12 19:32:56]

Done.

+  virtual bool IsPopupOrPanel(const TabContents* source) const OVERRIDE;
   virtual bool TakeFocus(bool reverse) OVERRIDE;
-  virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
 
   // Window that contains status area.
   // TODO(nkostylev): Temporary solution till we have
   // RenderWidgetHostViewViews working.
   views::Widget* status_window_;
 
   // Converts keyboard events on the TabContents to accelerators.
   UnhandledKeyboardEventHandler unhandled_keyboard_event_handler_;
 
   // Maps installed accelerators to OOBE webui accelerator identifiers.
   AccelMap accel_map_;
 
   // Proxy settings dialog that can be invoked from network menu.
   scoped_ptr<LoginHtmlDialog> proxy_settings_dialog_;
 
   // Watches webui_login_'s TabContents rendering.
   scoped_ptr<TabFirstRenderWatcher> tab_watcher_;
 
   // Whether the host window is frozen.
   bool host_window_frozen_;
 
   DISALLOW_COPY_AND_ASSIGN(WebUILoginView);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_WEBUI_LOGIN_VIEW_H_