Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/chromeos/login/webui_login_view.cc

Issue 7640023: [ChromeOS] WebUILoginView returns true for IsPopupOrPanel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nits Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/login/webui_login_view.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/webui_login_view.h" 5 #include "chrome/browser/chromeos/login/webui_login_view.h"
6 6
7 #include "chrome/browser/chromeos/accessibility_util.h" 7 #include "chrome/browser/chromeos/accessibility_util.h"
8 #include "chrome/browser/chromeos/login/proxy_settings_dialog.h" 8 #include "chrome/browser/chromeos/login/proxy_settings_dialog.h"
9 #include "chrome/browser/chromeos/login/webui_login_display.h" 9 #include "chrome/browser/chromeos/login/webui_login_display.h"
10 #include "chrome/browser/chromeos/status/clock_menu_button.h" 10 #include "chrome/browser/chromeos/status/clock_menu_button.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 241
242 bool WebUILoginView::HandleContextMenu(const ContextMenuParams& params) { 242 bool WebUILoginView::HandleContextMenu(const ContextMenuParams& params) {
243 // Do not show the context menu. 243 // Do not show the context menu.
244 #ifndef NDEBUG 244 #ifndef NDEBUG
245 return false; 245 return false;
246 #else 246 #else
247 return true; 247 return true;
248 #endif 248 #endif
249 } 249 }
250 250
251 bool WebUILoginView::IsPopupOrPanel(const TabContents* source) const {
252 return true;
253 }
254
251 bool WebUILoginView::TakeFocus(bool reverse) { 255 bool WebUILoginView::TakeFocus(bool reverse) {
252 // Forward the focus back to web contents. 256 // Forward the focus back to web contents.
253 webui_login_->tab_contents()->FocusThroughTabTraversal(reverse); 257 webui_login_->tab_contents()->FocusThroughTabTraversal(reverse);
254 return true; 258 return true;
255 } 259 }
256 260
257 void WebUILoginView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) { 261 void WebUILoginView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {
258 unhandled_keyboard_event_handler_.HandleKeyboardEvent(event, 262 unhandled_keyboard_event_handler_.HandleKeyboardEvent(event,
259 GetFocusManager()); 263 GetFocusManager());
260 264
261 // Make sure error bubble is cleared on keyboard event. This is needed 265 // Make sure error bubble is cleared on keyboard event. This is needed
262 // when the focus is inside an iframe. 266 // when the focus is inside an iframe.
263 WebUI* web_ui = GetWebUI(); 267 WebUI* web_ui = GetWebUI();
264 if (web_ui) 268 if (web_ui)
265 web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors"); 269 web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors");
266 } 270 }
267 271
268 } // namespace chromeos 272 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/webui_login_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698