Don't show wifi lock icon in the status bar.

Don't show wifi lock icon in the status bar.


BUG=chromium-os:18769
TEST=Lock icon for wifi should not be visible in the bottom-right corner in the status bar, but should still be visible in the menu and the network settings page. (See issue).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96578

[DaveMoore, 2011-08-12 16:57:49]

http://codereview.chromium.org/7637007/diff/2001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/network_menu_icon.cc (right):

http://codereview.chromium.org/7637007/diff/2001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/network_menu_icon.cc:182: is_status_bar_(true) {
I think this would be better named if it wasn't specific to the type of use, but
was a flag indicating whether the encrypted badge was to be used. Maybe
show_encrypted_badge? That's true unless you expect there to be more flags like
this to distinguish the status bar usage from others.

[stevenjb, 2011-08-12 17:19:47]

On 2011/08/12 16:57:49, DaveMoore wrote:
>
http://codereview.chromium.org/7637007/diff/2001/chrome/browser/chromeos/stat...
> File chrome/browser/chromeos/status/network_menu_icon.cc (right):
> 
>
http://codereview.chromium.org/7637007/diff/2001/chrome/browser/chromeos/stat...
> chrome/browser/chromeos/status/network_menu_icon.cc:182: is_status_bar_(true)
{
> I think this would be better named if it wasn't specific to the type of use,
but
> was a flag indicating whether the encrypted badge was to be used. Maybe
> show_encrypted_badge? That's true unless you expect there to be more flags
like
> this to distinguish the status bar usage from others.

Well, right now there are two fairly different places where we construct an icon
- for the status bar and for displaying the icon in a list. If an additional
differentiation comes up, it seems pretty likely that it will be a difference
between those cases, which is why I named it that way.

[DaveMoore, 2011-08-12 17:25:48]

lgtm