Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/chromeos/status/network_menu_icon.cc

Issue 7637007: Don't show wifi lock icon in the status bar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/status/network_menu_icon.h" 5 #include "chrome/browser/chromeos/status/network_menu_icon.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 8
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/chromeos/cros/cros_library.h" 10 #include "chrome/browser/chromeos/cros/cros_library.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 163 }
164 164
165 } // namespace 165 } // namespace
166 166
167 //////////////////////////////////////////////////////////////////////////////// 167 ////////////////////////////////////////////////////////////////////////////////
168 // NetworkIcon 168 // NetworkIcon
169 169
170 // Sets up and generates an SkBitmap for a Network icon. 170 // Sets up and generates an SkBitmap for a Network icon.
171 class NetworkIcon { 171 class NetworkIcon {
172 public: 172 public:
173 // Default constructor is used by the status bar icon (NetworkMenuIcon).
173 NetworkIcon() 174 NetworkIcon()
174 : state_(STATE_UNKNOWN), 175 : state_(STATE_UNKNOWN),
175 strength_index_(-1), 176 strength_index_(-1),
176 icon_(NULL), 177 icon_(NULL),
177 top_left_badge_(NULL), 178 top_left_badge_(NULL),
178 top_right_badge_(NULL), 179 top_right_badge_(NULL),
179 bottom_left_badge_(NULL), 180 bottom_left_badge_(NULL),
180 bottom_right_badge_(NULL) { 181 bottom_right_badge_(NULL),
182 is_status_bar_(true) {
DaveMoore 2011/08/12 16:57:49 I think this would be better named if it wasn't sp
181 } 183 }
182 184
185 // Service path constructor for cached network service icons.
183 explicit NetworkIcon(const std::string& service_path) 186 explicit NetworkIcon(const std::string& service_path)
184 : service_path_(service_path), 187 : service_path_(service_path),
185 state_(STATE_UNKNOWN), 188 state_(STATE_UNKNOWN),
186 strength_index_(-1), 189 strength_index_(-1),
187 icon_(NULL), 190 icon_(NULL),
188 top_left_badge_(NULL), 191 top_left_badge_(NULL),
189 top_right_badge_(NULL), 192 top_right_badge_(NULL),
190 bottom_left_badge_(NULL), 193 bottom_left_badge_(NULL),
191 bottom_right_badge_(NULL) { 194 bottom_right_badge_(NULL),
195 is_status_bar_(false) {
192 } 196 }
193 197
194 ~NetworkIcon() { 198 ~NetworkIcon() {
195 } 199 }
196 200
197 void ClearIconAndBadges() { 201 void ClearIconAndBadges() {
198 icon_ = NULL; 202 icon_ = NULL;
199 top_left_badge_ = NULL; 203 top_left_badge_ = NULL;
200 top_right_badge_ = NULL; 204 top_right_badge_ = NULL;
201 bottom_left_badge_ = NULL; 205 bottom_left_badge_ = NULL;
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 case TYPE_ETHERNET: { 296 case TYPE_ETHERNET: {
293 if (network->disconnected()) { 297 if (network->disconnected()) {
294 bottom_right_badge_ = 298 bottom_right_badge_ =
295 rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_DISCONNECTED); 299 rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_DISCONNECTED);
296 } 300 }
297 break; 301 break;
298 } 302 }
299 case TYPE_WIFI: { 303 case TYPE_WIFI: {
300 const WifiNetwork* wifi = 304 const WifiNetwork* wifi =
301 static_cast<const WifiNetwork*>(network); 305 static_cast<const WifiNetwork*>(network);
302 if (wifi->encrypted()) 306 if (wifi->encrypted() && !is_status_bar_)
303 bottom_right_badge_ = rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE); 307 bottom_right_badge_ = rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE);
304 break; 308 break;
305 } 309 }
306 case TYPE_CELLULAR: { 310 case TYPE_CELLULAR: {
307 const CellularNetwork* cellular = 311 const CellularNetwork* cellular =
308 static_cast<const CellularNetwork*>(network); 312 static_cast<const CellularNetwork*>(network);
309 if (cellular->roaming_state() == ROAMING_STATE_ROAMING) 313 if (cellular->roaming_state() == ROAMING_STATE_ROAMING)
310 top_left_badge_ = rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_ROAMING); 314 top_left_badge_ = rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_ROAMING);
311 if (!cellular->connecting()) 315 if (!cellular->connecting())
312 bottom_right_badge_ = BadgeForNetworkTechnology(cellular); 316 bottom_right_badge_ = BadgeForNetworkTechnology(cellular);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 private: 396 private:
393 std::string service_path_; 397 std::string service_path_;
394 ConnectionState state_; 398 ConnectionState state_;
395 int strength_index_; 399 int strength_index_;
396 SkBitmap bitmap_; 400 SkBitmap bitmap_;
397 const SkBitmap* icon_; 401 const SkBitmap* icon_;
398 const SkBitmap* top_left_badge_; 402 const SkBitmap* top_left_badge_;
399 const SkBitmap* top_right_badge_; 403 const SkBitmap* top_right_badge_;
400 const SkBitmap* bottom_left_badge_; 404 const SkBitmap* bottom_left_badge_;
401 const SkBitmap* bottom_right_badge_; 405 const SkBitmap* bottom_right_badge_;
406 bool is_status_bar_;
402 407
403 DISALLOW_COPY_AND_ASSIGN(NetworkIcon); 408 DISALLOW_COPY_AND_ASSIGN(NetworkIcon);
404 }; 409 };
405 410
406 411
407 //////////////////////////////////////////////////////////////////////////////// 412 ////////////////////////////////////////////////////////////////////////////////
408 // NetworkMenuIcon 413 // NetworkMenuIcon
409 414
410 NetworkMenuIcon::NetworkMenuIcon(Delegate* delegate, Mode mode) 415 NetworkMenuIcon::NetworkMenuIcon(Delegate* delegate, Mode mode)
411 : mode_(mode), 416 : mode_(mode),
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 ethernet_icon->width(), ethernet_icon->height(), false); 678 ethernet_icon->width(), ethernet_icon->height(), false);
674 canvas.DrawBitmapInt(*ethernet_icon, 0, 0); 679 canvas.DrawBitmapInt(*ethernet_icon, 0, 0);
675 const SkBitmap* vpn_badge = rb.GetBitmapNamed(kVpnBadgeId); 680 const SkBitmap* vpn_badge = rb.GetBitmapNamed(kVpnBadgeId);
676 canvas.DrawBitmapInt(*vpn_badge, kBadgeLeftX, kBadgeBottomY); 681 canvas.DrawBitmapInt(*vpn_badge, kBadgeLeftX, kBadgeBottomY);
677 vpn_bitmap = new SkBitmap(canvas.ExtractBitmap()); 682 vpn_bitmap = new SkBitmap(canvas.ExtractBitmap());
678 } 683 }
679 return vpn_bitmap; 684 return vpn_bitmap;
680 } 685 }
681 686
682 } // chromeos 687 } // chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698