Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/chromeos/status/network_menu_icon.cc

Issue 7637007: Don't show wifi lock icon in the status bar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/status/network_menu_icon.cc
diff --git a/chrome/browser/chromeos/status/network_menu_icon.cc b/chrome/browser/chromeos/status/network_menu_icon.cc
index e33634e24e7e1a9667597a4f03619fcc1c9ca833..fcc4baedefdc231bcb81f8c3afd4196579c32abf 100644
--- a/chrome/browser/chromeos/status/network_menu_icon.cc
+++ b/chrome/browser/chromeos/status/network_menu_icon.cc
@@ -170,6 +170,7 @@ const SkBitmap* BadgeForNetworkTechnology(const CellularNetwork* cellular) {
// Sets up and generates an SkBitmap for a Network icon.
class NetworkIcon {
public:
+ // Default constructor is used by the status bar icon (NetworkMenuIcon).
NetworkIcon()
: state_(STATE_UNKNOWN),
strength_index_(-1),
@@ -177,9 +178,11 @@ class NetworkIcon {
top_left_badge_(NULL),
top_right_badge_(NULL),
bottom_left_badge_(NULL),
- bottom_right_badge_(NULL) {
+ bottom_right_badge_(NULL),
+ is_status_bar_(true) {
DaveMoore 2011/08/12 16:57:49 I think this would be better named if it wasn't sp
}
+ // Service path constructor for cached network service icons.
explicit NetworkIcon(const std::string& service_path)
: service_path_(service_path),
state_(STATE_UNKNOWN),
@@ -188,7 +191,8 @@ class NetworkIcon {
top_left_badge_(NULL),
top_right_badge_(NULL),
bottom_left_badge_(NULL),
- bottom_right_badge_(NULL) {
+ bottom_right_badge_(NULL),
+ is_status_bar_(false) {
}
~NetworkIcon() {
@@ -299,7 +303,7 @@ class NetworkIcon {
case TYPE_WIFI: {
const WifiNetwork* wifi =
static_cast<const WifiNetwork*>(network);
- if (wifi->encrypted())
+ if (wifi->encrypted() && !is_status_bar_)
bottom_right_badge_ = rb.GetBitmapNamed(IDR_STATUSBAR_NETWORK_SECURE);
break;
}
@@ -399,6 +403,7 @@ class NetworkIcon {
const SkBitmap* top_right_badge_;
const SkBitmap* bottom_left_badge_;
const SkBitmap* bottom_right_badge_;
+ bool is_status_bar_;
DISALLOW_COPY_AND_ASSIGN(NetworkIcon);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698