Issue 7621068: Disable NaCl on 32-bit linux, also disable NaCl extension/store tests for that platform.

Issue 7621068: Disable NaCl on 32-bit linux, also disable NaCl extension/store tests for that platform. (Closed)

Created:
9 years, 4 months ago by elijahtaylor (use chromium)

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, awong

CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disable NaCl on 32-bit linux, also disable NaCl extension/store tests for that platform. BUG=93165 TEST=manual re-roll of http://codereview.chromium.org/7670055/, was reverted because tests weren't disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97440

Patch Set 3 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
M	chrome/browser/extensions/extension_nacl_browsertest.cc	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/native_client/test.html	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

1 nit http://codereview.chromium.org/7621068/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7621068/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode439 chrome/renderer/chrome_content_renderer_client.cc:439: #endif // !(Linux 32-bit) Usually the comment ...

9 years, 4 months ago (2011-08-18 17:36:27 UTC) #1

elijahtaylor (use chromium)

Just waiting on try jobs from my first patch http://codereview.chromium.org/7621068/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7621068/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode439 chrome/renderer/chrome_content_renderer_client.cc:439: ...

9 years, 4 months ago (2011-08-18 17:44:21 UTC) #2

Change committed as 97440

Expand Messages | Collapse Messages