Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 7670055: Disable NaCl on 32-bit linux (Closed)

Created:
9 years, 4 months ago by elijahtaylor (use chromium)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Disable NaCl on 32-bit linux BUG=93165 TEST= manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97285

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +6 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
elijahtaylor (use chromium)
9 years, 4 months ago (2011-08-18 00:15:08 UTC) #1
jam
http://codereview.chromium.org/7670055/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7670055/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode403 chrome/renderer/chrome_content_renderer_client.cc:403: const char* kNaClPluginMimeType = "application/x-nacl"; why move these?
9 years, 4 months ago (2011-08-18 00:17:59 UTC) #2
elijahtaylor (use chromium)
http://codereview.chromium.org/7670055/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7670055/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode403 chrome/renderer/chrome_content_renderer_client.cc:403: const char* kNaClPluginMimeType = "application/x-nacl"; On 2011/08/18 00:17:59, John ...
9 years, 4 months ago (2011-08-18 00:21:02 UTC) #3
jam
lgtm
9 years, 4 months ago (2011-08-18 00:26:48 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-18 08:25:22 UTC) #5
Change committed as 97285

Powered by Google App Engine
This is Rietveld 408576698