Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 7618028: Tweak typed-count Usage. (Closed)

Created:
9 years, 4 months ago by mrossetti
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Tweak typed-count Usage. Tweak how the typed count is used in the HistoryQuickProvider so that a typed_count of 1 is considered when presenting results. Adjusted usage of the three factors in RowQualifiesAsSignificant so that the comparison operations are the same. Adjusted unit tests since the tweak to RowQualifiesAsSignificant changes the expected results just a bit. BUG=77476 TEST=Adjusted unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97505

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M chrome/browser/autocomplete/history_quick_provider.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 2 3 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_types_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/url_database.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/url_database_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/History/url_history_provider_test.db.txt View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mrossetti
George, would you please take a look at these changes and see if there is ...
9 years, 4 months ago (2011-08-17 01:11:03 UTC) #1
GeorgeY
http://codereview.chromium.org/7618028/diff/7001/chrome/browser/autocomplete/history_url_provider_unittest.cc File chrome/browser/autocomplete/history_url_provider_unittest.cc (right): http://codereview.chromium.org/7618028/diff/7001/chrome/browser/autocomplete/history_url_provider_unittest.cc#newcode155 chrome/browser/autocomplete/history_url_provider_unittest.cc:155: HistoryQuickProvider::set_disabled(); That is a problem. HistoryQuickProvider's unit-tests are usually ...
9 years, 4 months ago (2011-08-18 21:34:37 UTC) #2
mrossetti
This is ready to review and is an M14 bug.
9 years, 4 months ago (2011-08-19 16:03:39 UTC) #3
Peter Kasting
9 years, 4 months ago (2011-08-19 16:16:05 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698