Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/history/url_database_unittest.cc

Issue 7618028: Tweak typed-count Usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/scoped_temp_dir.h" 8 #include "base/scoped_temp_dir.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 186
187 TEST_F(URLDatabaseTest, EnumeratorForSignificant) { 187 TEST_F(URLDatabaseTest, EnumeratorForSignificant) {
188 std::set<std::string> good_urls; 188 std::set<std::string> good_urls;
189 // Add URLs which do and don't meet the criteria. 189 // Add URLs which do and don't meet the criteria.
190 URLRow url_no_match(GURL("http://www.url_no_match.com/")); 190 URLRow url_no_match(GURL("http://www.url_no_match.com/"));
191 EXPECT_TRUE(AddURL(url_no_match)); 191 EXPECT_TRUE(AddURL(url_no_match));
192 192
193 std::string url_string2("http://www.url_match_visit_count.com/"); 193 std::string url_string2("http://www.url_match_visit_count.com/");
194 good_urls.insert("http://www.url_match_visit_count.com/"); 194 good_urls.insert("http://www.url_match_visit_count.com/");
195 URLRow url_match_visit_count(GURL("http://www.url_match_visit_count.com/")); 195 URLRow url_match_visit_count(GURL("http://www.url_match_visit_count.com/"));
196 url_match_visit_count.set_visit_count(kLowQualityMatchVisitLimit + 1); 196 url_match_visit_count.set_visit_count(kLowQualityMatchVisitLimit);
197 EXPECT_TRUE(AddURL(url_match_visit_count)); 197 EXPECT_TRUE(AddURL(url_match_visit_count));
198 198
199 good_urls.insert("http://www.url_match_typed_count.com/"); 199 good_urls.insert("http://www.url_match_typed_count.com/");
200 URLRow url_match_typed_count(GURL("http://www.url_match_typed_count.com/")); 200 URLRow url_match_typed_count(GURL("http://www.url_match_typed_count.com/"));
201 url_match_typed_count.set_typed_count(kLowQualityMatchTypedLimit + 1); 201 url_match_typed_count.set_typed_count(kLowQualityMatchTypedLimit);
202 EXPECT_TRUE(AddURL(url_match_typed_count)); 202 EXPECT_TRUE(AddURL(url_match_typed_count));
203 203
204 good_urls.insert("http://www.url_match_last_visit.com/"); 204 good_urls.insert("http://www.url_match_last_visit.com/");
205 URLRow url_match_last_visit(GURL("http://www.url_match_last_visit.com/")); 205 URLRow url_match_last_visit(GURL("http://www.url_match_last_visit.com/"));
206 url_match_last_visit.set_last_visit(Time::Now() - TimeDelta::FromDays(1)); 206 url_match_last_visit.set_last_visit(Time::Now() - TimeDelta::FromDays(1));
207 EXPECT_TRUE(AddURL(url_match_last_visit)); 207 EXPECT_TRUE(AddURL(url_match_last_visit));
208 208
209 URLRow url_no_match_last_visit(GURL( 209 URLRow url_no_match_last_visit(GURL(
210 "http://www.url_no_match_last_visit.com/")); 210 "http://www.url_no_match_last_visit.com/"));
211 url_no_match_last_visit.set_last_visit(Time::Now() - 211 url_no_match_last_visit.set_last_visit(Time::Now() -
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 IconMappingEnumerator e; 261 IconMappingEnumerator e;
262 InitIconMappingEnumeratorForEverything(&e); 262 InitIconMappingEnumeratorForEverything(&e);
263 IconMapping icon_mapping; 263 IconMapping icon_mapping;
264 ASSERT_TRUE(e.GetNextIconMapping(&icon_mapping)); 264 ASSERT_TRUE(e.GetNextIconMapping(&icon_mapping));
265 ASSERT_EQ(url1, icon_mapping.page_url); 265 ASSERT_EQ(url1, icon_mapping.page_url);
266 ASSERT_EQ(icon_id, icon_mapping.icon_id); 266 ASSERT_EQ(icon_id, icon_mapping.icon_id);
267 ASSERT_FALSE(e.GetNextIconMapping(&icon_mapping)); 267 ASSERT_FALSE(e.GetNextIconMapping(&icon_mapping));
268 } 268 }
269 269
270 } // namespace history 270 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/url_database.cc ('k') | chrome/test/data/History/url_history_provider_test.db.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698