Tweak typed-count Usage.

chrome/browser/autocomplete/history_url_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
+#include "chrome/browser/autocomplete/history_quick_provider.h"
 #include "chrome/browser/autocomplete/history_url_provider.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_browser_process_test.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/browser/browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Time;
 using base::TimeDelta;
 
 struct TestURLInfo {
   std::string url;
   std::string title;
   int visit_count;
   int typed_count;
 } test_db[] = {
   {"http://www.google.com/", "Google", 3, 3},
 
   // High-quality pages should get a host synthesized as a lower-quality match.
   {"http://slashdot.org/favorite_page.html", "Favorite page", 200, 100},
 
   // Less popular pages should have hosts synthesized as higher-quality
   // matches.
   {"http://kerneltrap.org/not_very_popular.html", "Less popular", 4, 0},
 
   // Unpopular pages should not appear in the results at all.
-  {"http://freshmeat.net/unpopular.html", "Unpopular", 1, 1},
+  {"http://freshmeat.net/unpopular.html", "Unpopular", 1, 0},
 
   // If a host has a match, we should pick it up during host synthesis.
   {"http://news.google.com/?ned=us&topic=n", "Google News - U.S.", 2, 2},
   {"http://news.google.com/", "Google News", 1, 1},
 
   // Suggested short URLs must be "good enough" and must match user input.
   {"http://foo.com/", "Dir", 5, 5},
   {"http://foo.com/dir/", "Dir", 2, 2},
   {"http://foo.com/dir/another/", "Dir", 5, 1},
   {"http://foo.com/dir/another/again/", "Dir", 10, 0},
@@ skipping 95 matching lines @@
     SetUpImpl(true);
   }
 };
 
 void HistoryURLProviderTest::OnProviderUpdate(bool updated_matches) {
   if (autocomplete_->done())
     MessageLoop::current()->Quit();
 }
 
 void HistoryURLProviderTest::SetUpImpl(bool no_db) {
+  HistoryQuickProvider::set_disabled();

[GeorgeY, 2011/08/18 21:34:37]

That is a problem. HistoryQuickProvider's unit-tests are usually run later in
the same process by trybots, but HistoryQuickProvider is going to stay disabled.
That is why Linux and Windows bots are failing. One possibility is to add friend
helper class that disabled HistoryQuickProvider in constructor and disables in
destructor.

   profile_.reset(new TestingProfile());
   profile_->CreateHistoryService(true, no_db);
   history_service_ = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
 
   autocomplete_ = new HistoryURLProvider(this, profile_.get(), "en-US,en,ko");
 
   FillData();
 }
 
 void HistoryURLProviderTest::TearDown() {
@@ skipping 126 matching lines @@
     "http://foo.com/dir/another/again/",
   };
   RunTest(ASCIIToUTF16("foo.com/dir/another/a"), string16(), true, short_4,
           arraysize(short_4));
 
   // Exact matches should always be best no matter how much more another match
   // has been typed.
   const std::string short_5a[] = {
     "http://gooey/",
     "http://www.google.com/",
+    "http://go/",
   };
   const std::string short_5b[] = {
     "http://go/",
     "http://gooey/",
     "http://www.google.com/",
   };
   RunTest(ASCIIToUTF16("g"), string16(), false, short_5a, arraysize(short_5a));
   RunTest(ASCIIToUTF16("go"), string16(), false, short_5b, arraysize(short_5b));
 }
 
@@ skipping 189 matching lines @@
                           false, true, AutocompleteInput::ALL_MATCHES);
   autocomplete_->Start(input, false);
   if (!autocomplete_->done())
     MessageLoop::current()->Run();
 
   // None of the matches should attempt to autocomplete.
   matches_ = autocomplete_->matches();
   for (size_t i = 0; i < matches_.size(); ++i)
     EXPECT_EQ(string16::npos, matches_[i].inline_autocomplete_offset);
 }