Pass clang flags to the host compiler, too.

Pass clang flags to the host compiler, too.

As of http://codereview.chromium.org/7471028, clang is used as
host compiler as well, so this check is no longer necessary. In
fact, it's harmful: In http://codereview.chromium.org/7550002 ,
a dependency on base is added on the host side, which doesn't
build with clang because e.g. -Wno-char-subscript isn't used,
which means base/third_party/dmg_fp/dtoa.cc doesn't build cleanly
in host compiler mode.

BUG=none
TEST=happy pkasting


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96121

[Peter Kasting, 2011-08-09 23:19:53]

LGTM (if I'm allowed!)

[Evan Martin, 2011-08-09 23:53:08]

Can you look at the blame to see why this was added? IIRC it fixed a
real problem.

On Tue, Aug 9, 2011 at 3:59 PM,  <thakis@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Pass clang flags to the host compiler, too.
>
> As of http://codereview.chromium.org/7471028, clang is used as
> host compiler as well, so this check is no longer necessary. In
> fact, it's harmful: In http://codereview.chromium.org/7550002 ,
> a dependency on base is added on the host side, which doesn't
> build with clang because e.g. -Wno-char-subscript isn't used,
> which means base/third_party/dmg_fp/dtoa.cc doesn't build cleanly
> in host compiler mode.
>
> BUG=none
> TEST=happy pkasting
>
>
> Please review this at http://codereview.chromium.org/7606012/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
8fb4dfa267e4f99bb1155973a3cce9a86a28be0b..554fcb4c839d392dafc26fdc61ab31d46994f566
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1501,24 +1501,21 @@
>               }]]
>           }],
>           ['clang==1', {
> -            'target_conditions': [
> -              ['_toolset=="target"', {
> -                'cflags': [
> -                  '-Wheader-hygiene',
> -                  # Clang spots more unused functions.
> -                  '-Wno-unused-function',
> -                  # Don't die on dtoa code that uses a char as an array
> index.
> -                  '-Wno-char-subscripts',
> -                  # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
> -                  # http://code.google.com/p/googletest/source/detail?r=446
> .
> -                  # TODO(thakis): Use -isystem instead
> (http://crbug.com/58751 )
> -                  '-Wno-unnamed-type-template-args',
> -                ],
> -                'cflags!': [
> -                  # Clang doesn't seem to know know this flag.
> -                  '-mfpmath=sse',
> -                ],
> -              }]],
> +            'cflags': [
> +              '-Wheader-hygiene',
> +              # Clang spots more unused functions.
> +              '-Wno-unused-function',
> +              # Don't die on dtoa code that uses a char as an array index.
> +              '-Wno-char-subscripts',
> +              # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
> +              # http://code.google.com/p/googletest/source/detail?r=446 .
> +              # TODO(thakis): Use -isystem instead (http://crbug.com/58751
> )
> +              '-Wno-unnamed-type-template-args',
> +            ],
> +            'cflags!': [
> +              # Clang doesn't seem to know know this flag.
> +              '-mfpmath=sse',
> +            ],
>           }],
>           ['clang==1 and clang_use_chrome_plugins==1', {
>             'target_conditions': [
>
>
>

[Nico, 2011-08-09 23:57:42]

On Tue, Aug 9, 2011 at 4:53 PM, Evan Martin <evan@chromium.org> wrote:
> Can you look at the blame to see why this was added? IIRC it fixed a
> real problem.

I'm pretty sure I added this, back when
http://code.google.com/p/chromium/wiki/Clang didn't recommend to set
CC.host…yep, here: http://codereview.chromium.org/6487005 You told me
to set CC.host and to remove this back then :-)

[commit-bot: I haz the power, 2011-08-10 03:07:13]

Change committed as 96121