Issue 6487005: clang: Set clang-specific flags on linux only if the target compiler is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6487005: clang: Set clang-specific flags on linux only if the target compiler is used. (Closed)

Created:
9 years, 10 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, hans

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

clang: Set clang-specific flags on linux only if the target compiler is used. The host compiler is hardcoded to gcc in the linux make build, and gcc does not understand all of these options. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74479

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -20 lines)			Patch
	M	build/common.gypi	View		1 chunk	+26 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 10 months ago (2011-02-10 20:18:46 UTC) #3

Hmm.  The host compiler is actually overridable just like the target compiler
is.  But this is probably OK for now.  LGTM

Expand Messages | Collapse Messages