Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 7471028: Set CC.host and CXX.host to clang as well on the clang bots. (Closed)

Created:
9 years, 5 months ago by Nico
Modified:
9 years, 5 months ago
CC:
chromium-reviews, hans, piman
Visibility:
Public.

Description

Set CC.host and CXX.host to clang as well on the clang bots. This allows us to get rid of the _toolset=="target" checks in common.gypi. I personally find it cleaner to default both CC.target and CC.host to CC and let the cross-compiler people set both these env vars, but piman didn't like that suggestion. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/scripts/slave/compile.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
This should also enable mac bots that build using make build & clang. I will ...
9 years, 5 months ago (2011-07-21 02:07:38 UTC) #1
Marc-Antoine Ruel (Google)
9 years, 5 months ago (2011-07-21 02:14:20 UTC) #2
I can only rubberstamp this since it's outside my knowledge area.
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698