Reduce number of unnamed-type-template-args violations.

net/http/http_stream_parser.h

Index: net/http/http_stream_parser.h
===================================================================
--- net/http/http_stream_parser.h	(revision 98480)
+++ net/http/http_stream_parser.h	(working copy)
@@ -94,16 +94,16 @@
 
   // The number of bytes by which the header buffer is grown when it reaches
   // capacity.
-  enum { kHeaderBufInitialSize = 4096 };
+  static const int kHeaderBufInitialSize;
 
   // |kMaxHeaderBufSize| is the number of bytes that the response headers can
   // grow to. If the body start is not found within this range of the
   // response, the transaction will fail with ERR_RESPONSE_HEADERS_TOO_BIG.
   // Note: |kMaxHeaderBufSize| should be a multiple of |kHeaderBufInitialSize|.
-  enum { kMaxHeaderBufSize = 256 * 1024 };  // 256 kilobytes.
+  static const int kMaxHeaderBufSize;
 
   // The maximum sane buffer size.
-  enum { kMaxBufSize = 2 * 1024 * 1024 };  // 2 megabytes.
+  static const int kMaxBufSize;

[wtc, 2011/08/26 21:20:53]

Please initialize these static const members in the header
file.  All the compilers we support can handle this now.
You can find existing usage in src/net by running this command
in the 'src' directory:

find net -name "*.h" | xargs grep "static const int"

[Peter Kasting, 2011/08/26 21:32:51]

AFAIK this is not technically legal until C++11.  Prevailing usage across all
Chromium is to initialize static consts in a single compilation unit, which is
also better for anyone porting this (e.g. the unofficial FreeBSD, Solaris, etc.
ports).  IMO it would be much better for any other similar usage in net/ to
change to match the rest of Chromium style.

[wtc, 2011/08/26 22:30:50]

To prepare myself for reviewing this CL, I consulted a few
books.  Effective C++ recommends that we initialize static
const int data members when declaring them, if the compiler
supports that.  Effective C++ was published before 2007.
So this must have become legal C++ before C++11.

Initializing static const int data members this way makes
the code easier to understand, and allows the compiler to
not allocate storage for the constants if no code ever
takes their addresses.

 
   // Handle callbacks.
   void OnIOComplete(int result);