Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_config.h

Issue 7605019: Reduce number of unnamed-type-template-args violations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_stream_parser.h ('K') | « net/http/http_stream_parser.cc ('k') | net/proxy/proxy_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config.h
===================================================================
--- net/proxy/proxy_config.h (revision 98480)
+++ net/proxy/proxy_config.h (working copy)
@@ -110,7 +110,7 @@
typedef int ID;
// Indicates an invalid proxy config.
- enum { INVALID_ID = 0 };
+ static const ID kInvalidConfigID;
wtc 2011/08/26 21:20:53 Please initialize this to 0 here in this header.
Peter Kasting 2011/08/26 21:32:51 See previous comment.
ProxyConfig();
ProxyConfig(const ProxyConfig& config);
@@ -120,7 +120,7 @@
// Used to numerically identify this configuration.
ID id() const { return id_; }
void set_id(int id) { id_ = id; }
- bool is_valid() const { return id_ != INVALID_ID; }
+ bool is_valid() const { return id_ != kInvalidConfigID; }
// Returns true if the given config is equivalent to this config.
bool Equals(const ProxyConfig& other) const;
« net/http/http_stream_parser.h ('K') | « net/http/http_stream_parser.cc ('k') | net/proxy/proxy_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698