Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/x509_cert_types_mac.cc

Issue 7605019: Reduce number of unnamed-type-template-args violations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/cert_database_nss_unittest.cc ('K') | « net/base/cert_status_flags.h ('k') | net/http/http_stream_parser.h » ('j') | net/http/http_stream_parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_cert_types_mac.cc
===================================================================
--- net/base/x509_cert_types_mac.cc (revision 98480)
+++ net/base/x509_cert_types_mac.cc (working copy)
@@ -36,11 +36,7 @@
// BER DistinguishedName structure.
struct KeyValuePair {
- CSSM_OID key;
- int value_type;
- CSSM_DATA value;
-
- enum {
+ enum ValueType {
kTypeOther = 0,
kTypePrintableString,
kTypeIA5String,
@@ -49,6 +45,10 @@
kTypeBMPString,
kTypeUniversalString,
};
+
+ CSSM_OID key;
+ ValueTypes value_type;
wtc 2011/08/26 21:20:53 BUG: this needs to be changed to ValueType, singul
Peter Kasting 2011/08/26 21:32:51 Thanks!
+ CSSM_DATA value;
};
const SecAsn1Template kStringValueTemplate[] = {
« net/base/cert_database_nss_unittest.cc ('K') | « net/base/cert_status_flags.h ('k') | net/http/http_stream_parser.h » ('j') | net/http/http_stream_parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698