Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2214)

Unified Diff: chrome/chrome_dll_syzygy.gypi

Issue 7598008: Revert overly-wide change in dependency chain. Now the new build step will only be enabled when ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: CL post merge resolution Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_dll_syzygy.gypi
===================================================================
--- chrome/chrome_dll_syzygy.gypi (revision 95883)
+++ chrome/chrome_dll_syzygy.gypi (working copy)
@@ -6,7 +6,13 @@
'optimize_with_syzygy%': 0,
},
'conditions': [
- ['OS=="win"', {
+ ['OS=="win" and optimize_with_syzygy==1', {
+ # Optimize the initial chrome DLL file, placing the optimized
+ # output and corresponding PDB file into the product directory.
+ # If fastbuild!=0 then no PDB files are generated by the build
+ # and the syzygy optimizations cannot run (they use the PDB
+ # information to properly understand the DLLs contents), so
+ # syzygy optimization cannot be performed.
'targets': [
{
'target_name': 'chrome_dll',
@@ -16,59 +22,29 @@
'chrome_dll_initial',
'chrome',
],
- 'conditions': [
- ['optimize_with_syzygy==1 and fastbuild==0', {
- # Optimize the initial chrome DLL file, placing the optimized
- # output and corresponding PDB file into the product directory.
- # If fastbuild!=0 then no PDB files are generated by the build
- # and the syzygy optimizations cannot run (they use the PDB
- # information to properly understand the DLLs contents), so
- # syzygy optimization cannot be performed.
- 'actions': [
- {
- 'action_name': 'Optimize Chrome binaries with syzygy',
- 'msvs_cygwin_shell': 0,
- 'inputs': [
- '<(PRODUCT_DIR)\\initial\\chrome.dll',
- '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
- ],
- 'outputs': [
- '<(PRODUCT_DIR)\\chrome.dll',
- '<(PRODUCT_DIR)\\chrome_dll.pdb',
- ],
- 'action': [
- '<(DEPTH)\\third_party\\syzygy\\binaries\\optimize.bat',
- '--verbose',
- '--input-dir="<(PRODUCT_DIR)"',
- '--input-dll="<(PRODUCT_DIR)\\initial\\chrome.dll"',
- '--input-pdb="<(PRODUCT_DIR)\\initial\\chrome_dll.pdb"',
- '--output-dir="<(INTERMEDIATE_DIR)\\optimized"',
- '--copy-to="<(PRODUCT_DIR)"',
- ],
- },
+ 'actions': [
+ {
+ 'action_name': 'Optimize Chrome binaries with syzygy',
+ 'msvs_cygwin_shell': 0,
+ 'inputs': [
+ '<(PRODUCT_DIR)\\initial\\chrome.dll',
+ '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
],
- }, { # optimize_with_syzygy!=1 or fastbuild!=0
- # Copy the chrome DLL and PDB files into the product directory.
- # If fastbuild!= 0 then there is no PDB file to copy.
- 'copies': [
- {
- 'destination': '<(PRODUCT_DIR)',
- 'conditions': [
- ['fastbuild==0', {
- 'files': [
- '<(PRODUCT_DIR)\\initial\\chrome.dll',
- '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
- ],
- }, {
- 'files': [
- '<(PRODUCT_DIR)\\initial\\chrome.dll',
- ],
- }],
- ],
- },
+ 'outputs': [
+ '<(PRODUCT_DIR)\\chrome.dll',
+ '<(PRODUCT_DIR)\\chrome_dll.pdb',
],
- }], # optimize_with_syzygy==0 or fastbuild==1
- ], # conditions
+ 'action': [
+ '<(DEPTH)\\third_party\\syzygy\\binaries\\optimize.bat',
+ '--verbose',
+ '--input-dir="<(PRODUCT_DIR)"',
+ '--input-dll="<(PRODUCT_DIR)\\initial\\chrome.dll"',
+ '--input-pdb="<(PRODUCT_DIR)\\initial\\chrome_dll.pdb"',
+ '--output-dir="<(INTERMEDIATE_DIR)\\optimized"',
+ '--copy-to="<(PRODUCT_DIR)"',
+ ],
+ },
+ ],
},
],
}],
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698