Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: chrome/chrome_dll.gypi

Issue 7598008: Revert overly-wide change in dependency chain. Now the new build step will only be enabled when ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: CL post merge resolution Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_dll.gypi
===================================================================
--- chrome/chrome_dll.gypi (revision 95883)
+++ chrome/chrome_dll.gypi (working copy)
@@ -66,7 +66,7 @@
'variables': {
'chrome_dll_target': 1,
'conditions' : [
- ['OS=="win"', {
+ ['OS=="win" and optimize_with_syzygy==1', {
# On Windows we use build chrome_dll as an intermediate target
# then have a subsequent step which either optimizes it to its
# final location, or copies it to its final location, depending
@@ -146,12 +146,17 @@
'msvs_settings': {
'VCLinkerTool': {
'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib',
- # On Windows we use build chrome_dll as an intermediate target
- # then have a subsequent step which either optimizes it to its
- # final location, or copies it to its final location, based
- # on whether or not optimize_with_syzygy==1.
- 'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb',
- 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
+ 'conditions': [
+ ['optimize_with_syzygy==1', {
+ # When syzygy is enabled we use build chrome_dll as an
+ # intermediate target then have a subsequent step which
+ # optimizes it to its final location
+ 'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb',
+ 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
+ }, {
+ 'ProgramDatabaseFile': '$(OutDir)\\chrome_dll.pdb',
+ }],
+ ],
},
},
}], # OS=="win"
« no previous file with comments | « no previous file | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698