Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: chrome/chrome_dll_syzygy.gypi

Issue 7598008: Revert overly-wide change in dependency chain. Now the new build step will only be enabled when ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: CL post merge resolution Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'optimize_with_syzygy%': 0, 6 'optimize_with_syzygy%': 0,
7 }, 7 },
8 'conditions': [ 8 'conditions': [
9 ['OS=="win"', { 9 ['OS=="win" and optimize_with_syzygy==1', {
10 # Optimize the initial chrome DLL file, placing the optimized
11 # output and corresponding PDB file into the product directory.
12 # If fastbuild!=0 then no PDB files are generated by the build
13 # and the syzygy optimizations cannot run (they use the PDB
14 # information to properly understand the DLLs contents), so
15 # syzygy optimization cannot be performed.
10 'targets': [ 16 'targets': [
11 { 17 {
12 'target_name': 'chrome_dll', 18 'target_name': 'chrome_dll',
13 'type': 'none', 19 'type': 'none',
14 'sources' : [], 20 'sources' : [],
15 'dependencies': [ 21 'dependencies': [
16 'chrome_dll_initial', 22 'chrome_dll_initial',
17 'chrome', 23 'chrome',
18 ], 24 ],
19 'conditions': [ 25 'actions': [
20 ['optimize_with_syzygy==1 and fastbuild==0', { 26 {
21 # Optimize the initial chrome DLL file, placing the optimized 27 'action_name': 'Optimize Chrome binaries with syzygy',
22 # output and corresponding PDB file into the product directory. 28 'msvs_cygwin_shell': 0,
23 # If fastbuild!=0 then no PDB files are generated by the build 29 'inputs': [
24 # and the syzygy optimizations cannot run (they use the PDB 30 '<(PRODUCT_DIR)\\initial\\chrome.dll',
25 # information to properly understand the DLLs contents), so 31 '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
26 # syzygy optimization cannot be performed.
27 'actions': [
28 {
29 'action_name': 'Optimize Chrome binaries with syzygy',
30 'msvs_cygwin_shell': 0,
31 'inputs': [
32 '<(PRODUCT_DIR)\\initial\\chrome.dll',
33 '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
34 ],
35 'outputs': [
36 '<(PRODUCT_DIR)\\chrome.dll',
37 '<(PRODUCT_DIR)\\chrome_dll.pdb',
38 ],
39 'action': [
40 '<(DEPTH)\\third_party\\syzygy\\binaries\\optimize.bat',
41 '--verbose',
42 '--input-dir="<(PRODUCT_DIR)"',
43 '--input-dll="<(PRODUCT_DIR)\\initial\\chrome.dll"',
44 '--input-pdb="<(PRODUCT_DIR)\\initial\\chrome_dll.pdb"',
45 '--output-dir="<(INTERMEDIATE_DIR)\\optimized"',
46 '--copy-to="<(PRODUCT_DIR)"',
47 ],
48 },
49 ], 32 ],
50 }, { # optimize_with_syzygy!=1 or fastbuild!=0 33 'outputs': [
51 # Copy the chrome DLL and PDB files into the product directory. 34 '<(PRODUCT_DIR)\\chrome.dll',
52 # If fastbuild!= 0 then there is no PDB file to copy. 35 '<(PRODUCT_DIR)\\chrome_dll.pdb',
53 'copies': [
54 {
55 'destination': '<(PRODUCT_DIR)',
56 'conditions': [
57 ['fastbuild==0', {
58 'files': [
59 '<(PRODUCT_DIR)\\initial\\chrome.dll',
60 '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
61 ],
62 }, {
63 'files': [
64 '<(PRODUCT_DIR)\\initial\\chrome.dll',
65 ],
66 }],
67 ],
68 },
69 ], 36 ],
70 }], # optimize_with_syzygy==0 or fastbuild==1 37 'action': [
71 ], # conditions 38 '<(DEPTH)\\third_party\\syzygy\\binaries\\optimize.bat',
39 '--verbose',
40 '--input-dir="<(PRODUCT_DIR)"',
41 '--input-dll="<(PRODUCT_DIR)\\initial\\chrome.dll"',
42 '--input-pdb="<(PRODUCT_DIR)\\initial\\chrome_dll.pdb"',
43 '--output-dir="<(INTERMEDIATE_DIR)\\optimized"',
44 '--copy-to="<(PRODUCT_DIR)"',
45 ],
46 },
47 ],
72 }, 48 },
73 ], 49 ],
74 }], 50 }],
75 ], 51 ],
76 } 52 }
OLDNEW
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698