Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/chrome_dll.gypi

Issue 7598008: Revert overly-wide change in dependency chain. Now the new build step will only be enabled when ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: CL post merge resolution Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'target_defaults': { 5 'target_defaults': {
6 'variables': { 6 'variables': {
7 'chrome_dll_target': 0, 7 'chrome_dll_target': 0,
8 }, 8 },
9 'target_conditions': [ 9 'target_conditions': [
10 ['chrome_dll_target==1', { 10 ['chrome_dll_target==1', {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 }], 59 }],
60 ], 60 ],
61 }, 61 },
62 'conditions': [ 62 'conditions': [
63 ['OS=="mac" or OS=="win"', { 63 ['OS=="mac" or OS=="win"', {
64 'targets': [ 64 'targets': [
65 { 65 {
66 'variables': { 66 'variables': {
67 'chrome_dll_target': 1, 67 'chrome_dll_target': 1,
68 'conditions' : [ 68 'conditions' : [
69 ['OS=="win"', { 69 ['OS=="win" and optimize_with_syzygy==1', {
70 # On Windows we use build chrome_dll as an intermediate target 70 # On Windows we use build chrome_dll as an intermediate target
71 # then have a subsequent step which either optimizes it to its 71 # then have a subsequent step which either optimizes it to its
72 # final location, or copies it to its final location, depending 72 # final location, or copies it to its final location, depending
73 # on whether or not optimize_with_syzygy==1. Please, refer to 73 # on whether or not optimize_with_syzygy==1. Please, refer to
74 # chrome_dll_syzygy.gypi for the subsequent defintion of the 74 # chrome_dll_syzygy.gypi for the subsequent defintion of the
75 # Windows chrome_dll target. 75 # Windows chrome_dll target.
76 'dll_target_name': 'chrome_dll_initial', 76 'dll_target_name': 'chrome_dll_initial',
77 }, { 77 }, {
78 'dll_target_name': 'chrome_dll', 78 'dll_target_name': 'chrome_dll',
79 }], 79 }],
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources.rc', 139 '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources.rc',
140 140
141 # TODO(sgk): left-over from pre-gyp build, figure out 141 # TODO(sgk): left-over from pre-gyp build, figure out
142 # if we still need them and/or how to update to gyp. 142 # if we still need them and/or how to update to gyp.
143 #'app/check_dependents.bat', 143 #'app/check_dependents.bat',
144 #'app/chrome.dll.deps', 144 #'app/chrome.dll.deps',
145 ], 145 ],
146 'msvs_settings': { 146 'msvs_settings': {
147 'VCLinkerTool': { 147 'VCLinkerTool': {
148 'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib', 148 'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib',
149 # On Windows we use build chrome_dll as an intermediate target 149 'conditions': [
150 # then have a subsequent step which either optimizes it to its 150 ['optimize_with_syzygy==1', {
151 # final location, or copies it to its final location, based 151 # When syzygy is enabled we use build chrome_dll as an
152 # on whether or not optimize_with_syzygy==1. 152 # intermediate target then have a subsequent step which
153 'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb', 153 # optimizes it to its final location
154 'OutputFile': '$(OutDir)\\initial\\chrome.dll', 154 'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb ',
155 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
156 }, {
157 'ProgramDatabaseFile': '$(OutDir)\\chrome_dll.pdb',
158 }],
159 ],
155 }, 160 },
156 }, 161 },
157 }], # OS=="win" 162 }], # OS=="win"
158 ['OS=="mac"', { 163 ['OS=="mac"', {
159 # The main browser executable's name is <(mac_product_name). 164 # The main browser executable's name is <(mac_product_name).
160 # Certain things will get confused if two modules in the 165 # Certain things will get confused if two modules in the
161 # executable share the same name, so append " Framework" to the 166 # executable share the same name, so append " Framework" to the
162 # product_name used for the framework. This will result in 167 # product_name used for the framework. This will result in
163 # a name like "Chromium Framework.framework". 168 # a name like "Chromium Framework.framework".
164 'product_name': '<(mac_product_name) Framework', 169 'product_name': '<(mac_product_name) Framework',
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 'LinkIncremental': '<(msvs_debug_link_nonincremental)', 731 'LinkIncremental': '<(msvs_debug_link_nonincremental)',
727 }, 732 },
728 }, 733 },
729 }, 734 },
730 }, 735 },
731 }, # target chrome_dll 736 }, # target chrome_dll
732 ], 737 ],
733 }], 738 }],
734 ], 739 ],
735 } 740 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698