Refactor webkit_glue::FormField to remove hacky methods

Refactor webkit_glue::FormField to remove hacky methods:  Remove webkit_glue::FormField's unwieldy full constructor and StricktlyEqualsHack() method.  The only clients are in test code, and we can better support these clients in other ways.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95928

[Ilya Sherman, 2011-08-05 03:27:36]

There are two TODOs which I would like to postpone to later CLs: (1) support for
sections, and (2) support for various credit card expiration date formats. 
Everything else should hopefully be ready for prime time.

[dhollowa, 2011-08-05 15:01:42]

Please split these into two patches (1) for ripping out ECML and (2) for adding
first round of autocompletetype support.  Thanks.

[Ilya Sherman, 2011-08-08 21:04:21]

Split off a bunch of changes into separate CLs; this is now purely a refactoring
CL in preparation for adding 'autocompletetype' support.

[dhollowa, 2011-08-08 21:40:39]

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_download_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_download_unittest.cc:130: field.label =
ASCIIToUTF16("username");
nit: It would be nice visually to have empty lines separating the logical chunks
(i.e. after each |push_back|).  And below.

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_manager_unittest.cc:266:
EXPECT_EQ(expected.max_length, actual.max_length);
This test is repeated in autofill_browsertest.cc and
form_manager_browsertest.cc.  It would be better to have a single definition (in
form_field.cc).  Also this version is missing a comparison of |is_autofilled|.

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/webdata/auto...
File chrome/browser/webdata/autofill_table_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/webdata/auto...
chrome/browser/webdata/autofill_table_unittest.cc:511: FormField field;
nit: Again, some visual separation would be helpful.

http://codereview.chromium.org/7576001/diff/14001/chrome/renderer/autofill/fo...
File chrome/renderer/autofill/form_manager_browsertest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/renderer/autofill/fo...
chrome/renderer/autofill/form_manager_browsertest.cc:151: SCOPED_TRACE("");
This is a touch magical.  It is also repeated everywhere.  This would be a good
candidate for a macro (ick) in form_field.h.

http://codereview.chromium.org/7576001/diff/14001/webkit/glue/form_field.cc
File webkit/glue/form_field.cc (right):

http://codereview.chromium.org/7576001/diff/14001/webkit/glue/form_field.cc#n...
webkit/glue/form_field.cc:53: << field.max_length;
This is missing |is_autofilled|.

[Ilya Sherman, 2011-08-09 00:13:43]

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_download_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_download_unittest.cc:130: field.label =
ASCIIToUTF16("username");
On 2011/08/08 21:40:39, dhollowa wrote:
> nit: It would be nice visually to have empty lines separating the logical
chunks
> (i.e. after each |push_back|).  And below.

Done.

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_manager_unittest.cc:266:
EXPECT_EQ(expected.max_length, actual.max_length);
On 2011/08/08 21:40:39, dhollowa wrote:
> This test is repeated in autofill_browsertest.cc and
> form_manager_browsertest.cc.  It would be better to have a single definition
(in
> form_field.cc).  Also this version is missing a comparison of |is_autofilled|.

This version is intentionally missing the |is_autofilled| check.  I've rewritten
this function to be more explicit in its expectations -- this also makes the
below code cleaner.

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/webdata/auto...
File chrome/browser/webdata/autofill_table_unittest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/browser/webdata/auto...
chrome/browser/webdata/autofill_table_unittest.cc:511: FormField field;
On 2011/08/08 21:40:39, dhollowa wrote:
> nit: Again, some visual separation would be helpful.

Done.

http://codereview.chromium.org/7576001/diff/14001/chrome/renderer/autofill/fo...
File chrome/renderer/autofill/form_manager_browsertest.cc (right):

http://codereview.chromium.org/7576001/diff/14001/chrome/renderer/autofill/fo...
chrome/renderer/autofill/form_manager_browsertest.cc:151: SCOPED_TRACE("");
On 2011/08/08 21:40:39, dhollowa wrote:
> This is a touch magical.  It is also repeated everywhere.  This would be a
good
> candidate for a macro (ick) in form_field.h.

Done.

http://codereview.chromium.org/7576001/diff/14001/webkit/glue/form_field.cc
File webkit/glue/form_field.cc (right):

http://codereview.chromium.org/7576001/diff/14001/webkit/glue/form_field.cc#n...
webkit/glue/form_field.cc:53: << field.max_length;
On 2011/08/08 21:40:39, dhollowa wrote:
> This is missing |is_autofilled|.

Done.

[dhollowa, 2011-08-09 00:22:07]

LGTM.  Thanks.

[commit-bot: I haz the power, 2011-08-09 01:14:00]

Can't process patch for file
chrome/renderer/autofill/password_autofill_manager_browsertest.cc.
A +