Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: webkit/glue/form_field.cc

Issue 7576001: Refactor webkit_glue::FormField to remove hacky methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix copyright header Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/form_field.h ('k') | webkit/glue/password_form_dom_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/form_field.cc
diff --git a/webkit/glue/form_field.cc b/webkit/glue/form_field.cc
index e38495737b0dea83012807fc3cc03701f65b4165..798c5b2f28dd317d31488da27177680aeb82351e 100644
--- a/webkit/glue/form_field.cc
+++ b/webkit/glue/form_field.cc
@@ -24,20 +24,6 @@ FormField::FormField()
is_autofilled(false) {
}
-FormField::FormField(const string16& label,
- const string16& name,
- const string16& value,
- const string16& form_control_type,
- int max_length,
- bool is_autofilled)
- : label(label),
- name(name),
- value(value),
- form_control_type(form_control_type),
- max_length(max_length),
- is_autofilled(is_autofilled) {
-}
-
FormField::~FormField() {
}
@@ -54,14 +40,6 @@ bool FormField::operator!=(const FormField& field) const {
return !operator==(field);
}
-bool FormField::StrictlyEqualsHack(const FormField& field) const {
- return (label == field.label &&
- name == field.name &&
- value == field.value &&
- form_control_type == field.form_control_type &&
- max_length == field.max_length);
-}
-
std::ostream& operator<<(std::ostream& os, const FormField& field) {
return os
<< UTF16ToUTF8(field.label)
@@ -72,7 +50,9 @@ std::ostream& operator<<(std::ostream& os, const FormField& field) {
<< " "
<< UTF16ToUTF8(field.form_control_type)
<< " "
- << field.max_length;
+ << field.max_length
+ << " "
+ << (field.is_autofilled ? "true" : "false");
}
} // namespace webkit_glue
« no previous file with comments | « webkit/glue/form_field.h ('k') | webkit/glue/password_form_dom_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698